Add SelectPopover component #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 26, 2018 16:32
- Display list of elements in a popover - Store selected element in state - Add callbacks to know when the selected element changed
This will allow us to set many options in there.
mariussturm
reviewed
Feb 27, 2018
| @@ -95,7 +95,7 @@ const SelectPopoverFormattedExample = createReactClass({ | |||
| filterPlaceholder="Filter by colour" /> | |||
| </div> | |||
|
|
|||
| {selectedItem ? `You have selected ${selectedItem}` : 'Please select a colour!'} | |||
| {selectedItem ? `You have selected ${selectedItem}` : 'Please select another colour!'} | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
SelectPopovercomponent that we want to use on actions and filters inTableListcomponents:Some features of this component: