Upgrade jQuery to 3.3.1 #4507
Merged
Upgrade jQuery to 3.3.1 #4507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 23, 2018 15:38
Also bump dependencies relying on jquery, although currently only toastr had a new version.
Also try to make code more readable.
ghost
assigned 
|
Apart from the changes in the PR, I saw deprecation warnings using the jQuery migrate plugin in toastr, typeahead, and jquery-ui. So far we cannot address those warnings since we are already using the latest version of those libraries. From my point of view this is ready to be reviewed, I think we should focus our efforts in moving away from the few jQuery plugins we use instead of fixing those deprecations. |
|
I like what you did here :) |
kmerz
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bump dependencies relying on jQuery (currently only toastr has a new bugfix version).
As this is a long version jump and there are many changes in jQuery as you can see in the release notes for 3.0, 3.1, 3.2, and 3.3.
Fortunately for us, 3.0 was developed with backwards compatibility in mind, so most of the changes that affect us are deprecations. On the other hand, most of the jQuery code we run is coming through 3rd party plugins, so we may have some problems to get fixes in them.
As recommended, I'm running the web interface with the jQuery Migrate plugin to be able to see deprecations and changes we need to address.