Only display dashboards with write permissions in add to dashboard menu #4505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 23, 2018 12:34
This store is using ImmutableJS to store the dashboards state, and it should do the same with the writableDashboards
ghost
assigned 
|
This PR should also be backported into the 2.4 branch. |
|
I didn't fix all linter errors in |
|
LGTM 👍 |
kmerz
approved these changes
Jan 24, 2018
kmerz
pushed a commit
that referenced
this pull request
Jan 24, 2018
…nu (#4505) * Add tests for issue * Only display dashboards with write access in menu * Update current user permissions with the initial state * Make writableDashboards consistent with dashboards This store is using ImmutableJS to store the dashboards state, and it should do the same with the writableDashboards * Fix eslint errors on test
edmundoa
pushed a commit
that referenced
this pull request
Jan 24, 2018
…nu (#4505) (#4511) * Add tests for issue * Only display dashboards with write access in menu * Update current user permissions with the initial state * Make writableDashboards consistent with dashboards This store is using ImmutableJS to store the dashboards state, and it should do the same with the writableDashboards * Fix eslint errors on test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures users can only see dashboards with write permissions in the add to dashboard menu. Additionally it makes the state in
DashboardsStore.list()consistent by using ImmutableJS in all its properties, and it ensures the permissions inDashboardsStoreare set when the store is first initialized. I also added a couple of tests, to ensure all cases are doing what they should.Fixes #4504