Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of dev server host #4500

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Conversation

edmundoa
Copy link
Contributor

@edmundoa edmundoa commented Jan 22, 2018

Looking into the development server for the web interface, we saw that it was listening to all interfaces by default, so this PR changes that behaviour by:

  • Using localhost as default
  • Adding --host option to change the default host where the server should listen
  • Documenting changes in README file

- Use localhost by default
- Add --host option to change the default value
- Document changes in README
@edmundoa edmundoa added this to the 3.0.0 milestone Jan 22, 2018
@edmundoa edmundoa requested a review from bernd January 22, 2018 16:22
@ghost ghost assigned edmundoa Jan 22, 2018
@bernd bernd assigned bernd and unassigned edmundoa Jan 22, 2018
@bernd bernd merged commit bf72a0f into master Jan 22, 2018
@bernd bernd deleted the custom-dev-server-host branch January 22, 2018 17:05
@ghost ghost removed the ready-for-review label Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants