Remove 2 way binding #4390
Merged
Remove 2 way binding #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
edmundoa
force-pushed
the
remove-2-way-binding
branch
from
557fde9 to
09ff634
Compare
added 8 commits
December 5, 2017 11:52
Also needed to refactor MetricsFilterInput a bit to get it working.
edmundoa
force-pushed
the
remove-2-way-binding
branch
from
09ff634 to
4edd1a8
Compare
Also add graylog-web-plugin yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since React v15,
LinkedStateMixinis deprecated — see https://reactjs.org/docs/two-way-binding-helpers.html for more details.This PR replaces that mixin with
valueandonChangein our code, and also takes care of fixing some small issues in the affected components.