Do not show global notifications in 404 page #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned Avoid displaying global notifications in not found page. So far other error pages will not be affected, as they are rendered before react-router is used.
edmundoa
force-pushed
the
remove-404-global-notification
branch
from
95b1737 to
f4ea9e5
Compare
edmundoa
force-pushed
the
remove-404-global-notification
branch
from
f4ea9e5 to
9c3845a
Compare
kroepke
approved these changes
Dec 4, 2017
edmundoa
added a commit
that referenced
this pull request
Dec 4, 2017
* Do not show global notifications in error pages Avoid displaying global notifications in not found page. So far other error pages will not be affected, as they are rendered before react-router is used. * Fix linter errors (cherry picked from commit a58f56f)
bernd
pushed a commit
that referenced
this pull request
Dec 4, 2017
* Do not show global notifications in error pages Avoid displaying global notifications in not found page. So far other error pages will not be affected, as they are rendered before react-router is used. * Fix linter errors (cherry picked from commit a58f56f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid displaying global notifications in the not found page. Other error pages do not need to be taken in consideration at this point, as they are rendered before react-router, and therefore do not render the global notifications component.