Web dev improvements #4388
Merged
Web dev improvements #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
added 8 commits
December 5, 2017 11:33
Let users customize port number by passing `--port=<port>` as argument. If the port is already taken, we will start the web interface in a random one.
Changed it accidentally during some tests.
The `start` build using HMR alongside react-hot-loader was already not working as it should with webpack-dev-server. Modules got reloaded, but the application state was reset on every change. I have been trying a couple of times to make HMR work with the new express dev server, but I just managed to reproduce what it achieved in the previous build (reloading the whole component tree, but losing the state). All of that making the current webpack configuration more complicated. I think react-hot-loader is a good idea that can be helpful specially when styling components, but currently I see that it produces way too maintenance burden for the benefits it provides. Also, nobody in the team seems to be using it for development. Long story short, this commit removes react-hot-loader from our dev build. We still use Webpack HMR to reload the browser. The commit also replaces the `start` script with `start-nohmr`, so running `yarn start` will use the no react-hot-loader dev server.
- Include details to use yarn in development - Remove old warnings and information - Remove mentions of the react-hot-loader build - Update information on upgrade packages - Update information on IntelliJ setup
edmundoa
force-pushed
the
web-dev-improvements
branch
from
84e9ff6 to
acf9dea
Compare
This was referenced Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last few weeks we did quite a few changes in the development toolchain we use in the web interface, resulting in unfinished configurations, confusing scripts running different tools, and outdated documentation (or, let's say, even useless documentation).
This PR fixes at least some of those problems by:
start-nohmr) is now used inyarn start, as that is the most conventional script name to run an applicationI hope all this changes help making the setup easier to understand and clearer.