Skip to content
This repository was archived by the owner on Mar 21, 2023. It is now read-only.

Use friendlier error message in case of invalid expressions #196

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Jul 5, 2017

Instead of throwing a NullPointerException for invalid unary expression where the constructor parameter right is null and for which the call to UnaryExpression#getType() will subsequently fail, the constructor now explicitly throws a ParseException with a SyntaxError (fail fast).

Closes #185

@joschi joschi added this to the 2.3.0 milestone Jul 5, 2017
@joschi joschi requested a review from kroepke July 5, 2017 09:41
@bernd bernd self-assigned this Jul 5, 2017
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 👍

@bernd bernd merged commit 7038153 into master Jul 5, 2017
@bernd bernd deleted the issue-185 branch July 5, 2017 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants