Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Netty 4.1 #30

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Migrate to Netty 4.1 #30

merged 1 commit into from
Jan 18, 2018

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Dec 5, 2017

@joschi joschi added this to the 3.0.0 milestone Dec 5, 2017
@ghost ghost assigned joschi Dec 5, 2017
@joschi joschi force-pushed the netty-4 branch 2 times, most recently from 792c85c to 3e9a485 Compare December 11, 2017 11:11
@bernd
Copy link
Member

bernd commented Jan 11, 2018

@joschi I am getting the following compilation error now:

[ERROR] graylog-project-repos/graylog-plugin-beats/src/main/java/org/graylog/plugins/beats/BeatsTransport.java:[45,9] constructor AbstractTcpTransport in class org.graylog2.plugin.inputs.transports.AbstractTcpTransport cannot be applied to given types;
  required: org.graylog2.plugin.configuration.Configuration,org.graylog2.plugin.inputs.util.ThroughputCounter,org.graylog2.plugin.LocalMetricRegistry,io.netty.channel.EventLoopGroup,org.graylog2.inputs.transports.netty.EventLoopGroupFactory,org.graylog2.inputs.transports.NettyTransportConfiguration
  found: org.graylog2.plugin.configuration.Configuration,org.graylog2.plugin.inputs.util.ThroughputCounter,org.graylog2.plugin.LocalMetricRegistry,io.netty.channel.EventLoopGroup,org.graylog2.inputs.transports.NettyTransportConfiguration
  reason: actual and formal argument lists differ in length

@joschi
Copy link
Contributor Author

joschi commented Jan 11, 2018

@bernd The branch was missing a force push with the latest changes.

bernd
bernd approved these changes Jan 18, 2018
View reviewed changes
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joschi Thanks for the good work! 👍

@bernd bernd merged commit 20b05ff into master Jan 18, 2018
@ghost ghost removed the ready-for-review label Jan 18, 2018
@bernd bernd deleted the netty-4 branch January 18, 2018 10:19
@bernd bernd mentioned this pull request Jan 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernd bernd bernd approved these changes

Assignees

@joschi joschi

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joschi @bernd