Remove page JS #889
Merged
Remove page JS #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/decaffeinate/decaffeinate Note, I left the improvement suggestion comments as I do not currently have the time to address them
…s, moving the data to hidden inputs with embedded JSON data to be extracted from jQuery Refactor all other data.categories embedded data to work the same way Small expose comment fixes Fix type in ajax calls to be method Disable turbolinks caches, as it creates rendering issues and the app wasn't built for it Specify categories routes rather than listing some that aren't used
…export when external id is entered
…s fields for new organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert coffeescript to regular JS using the decaffeinate tool (https://github.com/decaffeinate/decaffeinate). Remove embedded JS because turbolinks does not play well with embedded page JS. I converted the embedded data in the JS to hidden fields with jQuery data attributes that can then be converted to JS object data.