Merge pull request #893 from GratefulGarmentProject/donation-journal-…

…exports

Add more external ids to tables and some small rubocop fixes (more to come)

.rubocop.yml

@@ -14,7 +14,7 @@ Documentation:
   Enabled: false
 
 Layout/LineLength:
-  Max: 120
+  Max: 150
   Exclude:
     - spec/**/*
 

app/models/net_suite_integration.rb

@@ -8,7 +8,7 @@ def self.host
     "#{NetSuite::Configuration.account}.app.netsuite.com"
   end
 
-  def self.path(object, prefix: nil) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+  def self.path(object, prefix: nil) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity, Metrics/AbcSize
     case object
     when Order
       if prefix == :journal

app/views/donations/_table.html.erb

@@ -6,8 +6,9 @@
       <th class="col-xs-2">Items</th>
       <th class="col-xs-2">Value</th>
 
-      <% if local_assigns[:for_closed] %>
-        <th class="col-xs-1">External Id</th>
+      <% if current_user.can_sync_donations? && local_assigns[:for_closed] %>
+        <th class="col-xs-1">Ext Id</th>
+        <th class="col-xs-1">Journal Ext Id</th>
       <% end %>
 
       <th class="col-xs-1">Date Received</th>
@@ -28,8 +29,9 @@
         <td><%= donation.item_count %></td>
         <td><%= number_to_currency(donation.value, unit: "$", precision: 2) %></td>
 
-        <% if local_assigns[:for_closed] %>
+        <% if current_user.can_sync_donations? && local_assigns[:for_closed] %>
           <td><%= external_id_or_status(donation, link: true) %></td>
+          <td><%= external_id_or_status(donation, link: true, prefix: :journal) %></td>
         <% end %>
 
         <td><%= donation.formatted_donation_date %></td>

app/views/orders/_table.html.erb

@@ -8,8 +8,9 @@
         <th>Date Received</th>
         <th>Status</th>
 
-        <% if local_assigns[:for_closed] %>
-          <th>External Id</th>
+        <% if current_user.can_sync_orders? && local_assigns[:for_closed] %>
+          <th>Ext Id</th>
+          <th>Journal Ext Id</th>
         <% end %>
 
         <th>Tracking Number</th>
@@ -25,8 +26,9 @@
             <td><%= order.formatted_order_date %></td>
             <td><%= order.status.titleize %></td>
 
-            <% if local_assigns[:for_closed] %>
+            <% if current_user.can_sync_orders? && local_assigns[:for_closed] %>
               <td><%= external_id_or_status(order, link: true) %></td>
+              <td><%= external_id_or_status(order, link: true, prefix: :journal) %></td>
             <% end %>
 
             <td>

app/views/purchases/_table.html.erb

@@ -8,7 +8,7 @@
         <th>Date Entered</th>
         <th>Status</th>
 
-        <% if local_assigns[:for_closed] %>
+        <% if current_user.can_sync_purchases? && local_assigns[:for_closed] %>
           <th>External Id</th>
           <th>Journal External Id</th>
         <% end %>
@@ -24,7 +24,7 @@
           <td><%= purchase.formatted_purchase_date %></td>
           <td><%= purchase.status.titleize %></td>
 
-          <% if local_assigns[:for_closed] %>
+          <% if current_user.can_sync_purchases? && local_assigns[:for_closed] %>
             <td><%= external_id_or_status(purchase, link: true) %></td>
             <td><%= external_id_or_status(purchase, link: true, prefix: :variance) %></td>
           <% end %>