Skip to content

Commit

Permalink
Address rubocop issues
Browse files Browse the repository at this point in the history
  • Loading branch information
smellsblue committed May 14, 2024
1 parent 196b5b4 commit 6d5729a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions app/models/net_suite_integration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def self.host
"#{NetSuite::Configuration.account}.app.netsuite.com"
end

def self.path(object, prefix: nil) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength
def self.path(object, prefix: nil) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
case object
when Order
if prefix == :journal
Expand Down Expand Up @@ -134,10 +134,10 @@ def self.export_not_applicable?(object, prefix: nil)
# Check if any of the multiple exports for the object were unsuccessful, which
# can be used to see if it is still eligible to be synced.
def self.any_not_exported_successfully?(object, additional_prefixes:)
return true if !exported_successfully?(object)
return true unless exported_successfully?(object)

[additional_prefixes].flatten.each do |prefix|
return true if !exported_successfully?(object, prefix: prefix)
return true unless exported_successfully?(object, prefix: prefix)
end

false
Expand Down
2 changes: 1 addition & 1 deletion app/models/net_suite_integration/order_exporter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def assign_native_netsuite_attributes
journal_entry_record.tran_date = order.order_date.strftime "%Y-%m-%dT%H:%M:%S.%L%z"
end

def add_line_items
def add_line_items # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
total_value = order.value

journal_entry_record.line_list << NetSuite::Records::JournalEntryLine.new.tap do |item|
Expand Down

0 comments on commit 6d5729a

Please sign in to comment.