Add embedable images by 0HyperCube · Pull Request #564 · GraphiteEditor/Graphite

0HyperCube · 2022-02-21T21:17:17Z

Closes #188

This is really slow for large images as we are cloning the base64 string every render then sending it to js.

TODO:

Convert to blob url
Ctrl + V to paste (I couldn't get this to work on the svg Edit: Turns out we have prevent default on the key up event that was blocking it)
Add properties
Rename to image
Properly handle bounding box
Remove logging

Keavon · 2022-02-21T21:19:55Z

Sweet! To fix the base64 slowness, you can try sending the image data to the frontend just once and turn it into a blob URL then reference the blob URL as the image path.

cloudflare-workers-and-pages · 2022-02-21T21:25:22Z

Deploying with Cloudflare Pages

Latest commit:	`b480138`
Status:	✅ Deploy successful!
Preview URL:	https://5a290261.graphite-master.pages.dev

View logs

Keavon · 2022-03-05T09:18:34Z

One neat thing I just discovered: this even works with SVGs! So maybe a better name than "Bitmap" would be "Image". I can also provide you with an icon for this layer type.

Keavon · 2022-03-06T07:54:21Z

@0HyperCube I added an image node type icon for you in 97eca6d :)

Keavon · 2022-03-16T22:59:19Z

I've noticed that copying and pasting image layers causes the new image layers to be zero in size, or somehow otherwise invisible with a zero-sized bounding box. Any idea what's causing that?

0HyperCube · 2022-03-21T20:58:55Z

@Keavon Forgot to send the image data to the frontend on paste (which sends back both the blob url and the image dimensions). That should now be resolved.

Keavon · 2022-03-21T21:35:31Z

@0HyperCube awesome. Are we good to rebase and then begin code review?

0HyperCube · 2022-03-24T18:19:38Z

@Keavon Sure, I will just try and fix the failing test.

Keavon

Looking great! Just a few review comments for you. Feel free to merge when those are addressed. This was a great feature to have when making the Yosemite Valley artwork!

Keavon · 2022-03-27T08:19:25Z

editor/src/communication/dispatcher.rs

 				Frontend(message) => {
+					// Image data should be immediatly handled
+					if let FrontendMessage::UpdateImageData { .. } = message {
+						self.responses.push(message);


This is the same line as the line below, so the identical code runs in either case, right?

No - it returns from the function in this case.The check needs to be before pushing the message to prevent a clone.

editor/src/document/layer_panel.rs

frontend/src/components/panels/Document.vue

graphene/src/layers/layer_info.rs

graphene/src/document.rs

frontend/wasm/src/api.rs

* Add embedable bitmaps * Initial work on blob urls * Finish implementing data url * Fix some bugs * Rename bitmap to image * Fix loading image on document load * Add transform properties for image * Remove some logging * Add image dimensions * Implement system copy and paste * Fix pasting images * Fix test * Address code review Co-authored-by: Keavon Chambers <keavon@keavon.com>

@caleb-ad

* changed path_intersection structure * comment * Removed do_if! * Create project website with near-complete home page * Added support for undoing - i gotta say the undo system is quite nice * Website responsive resizing improvements * Add newsletter signup to website * Pen tool fixes (#563) Resolves 3 known bugs with the pen tool. * Fixed crash pointed out by @caleb-ad * Fixed issue with final path segment losing handle data * Replace curves with lines when under a drag threshold, improves usability. * Readability improvements, improved comments * Color Input (#565) * initial working prototype * clean up component * Fix alignment * Code review tweaks Co-authored-by: Keavon Chambers <keavon@keavon.com> * Made the non-inclusive end of a pathseg less inclusive Fixed Bug: When doing a closepath it is possible that the current and beginning edge are both None Fixed Numerous other things * changed how closepath works modified how overlapping_curve_intersections is working * Add "New Folder"/"Delete Selected" buttons to layer panel Closes #532 * Update npm dependencies * Set text color based on its fill when it's being edited * Reorder tool icons, update favicon and logo, and other icon cleanup * Bug Fix: Line-Line intersect origin wasn't being preserved * Bug Fix: proper assignment of t_values in overlapping_curve_intersections * Honestly, i don't even know what I was thinking when i wrote the logic for splitting a subcurve at endpoints, but it was wrong. * Feature: overlapping rectangles behave properly, (except when intersections aren't found correctly) * Remake node type icons (closes #483); color picker cleanup * Change tool shelf icon colors to use classes not style * Add Image node icon and rename node from Path to Shape * Bug Fix: proper intersection construction in partial overlap case * cleaned up log statements * Add website revisions and many new pages * Add features page and fixes to website * Fix clippy lints and update packages (#568) * Fix type error in Brave browser (#569) * Small website text improvements * Various website fixes * Adjusted constants Rearranged intersection algorithm * Changed BooleanOperation::SubtractBack to use SubtractFront Added composite_boolean_operation for operations with more than one shape * Add node graph mockup to website * Differentiate between scale and dimensions (#570) * Differentiate between scale and dimensions * Fix layout and naming of properties * Add embedable images (#564) * Add embedable bitmaps * Initial work on blob urls * Finish implementing data url * Fix some bugs * Rename bitmap to image * Fix loading image on document load * Add transform properties for image * Remove some logging * Add image dimensions * Implement system copy and paste * Fix pasting images * Fix test * Address code review Co-authored-by: Keavon Chambers <keavon@keavon.com> * Bump minimist from 1.2.5 to 1.2.6 in /frontend (#571) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix panic dialogue when handling a message (#573) * Fix panic dialogue when handling a message * Fix indents for github reporting * More whitespace improvements * Save: line_intersection * Add documentation to many parts of the Rust codebase (#552) * add lots of doccomments * add conversion traits from layerdatatypes to layers * add suggested doc improvements * Code review changes Co-authored-by: Keavon Chambers <keavon@keavon.com> * Add additional stroke properties (#582) * Add aditional stroke properties * Add comment explaining clones for closure * Improve labels * Fix doc test Co-authored-by: Keavon Chambers <keavon@keavon.com> * Bug Fix: .y not .x * Expand upon the "Announcing Graphite alpha" blog post * All shapes now have a Fill in the properties panel; color inputs are now optional (#583) * Add aditional stroke properties * Make the colour input optional * Fix fmt * Apply code review changes * Code review nitpicks * Fix recursion Co-authored-by: Keavon Chambers <keavon@keavon.com> * New blog post: "Distributed computing with the Graphene runtime" * Fix gradient transformation (#588) * Fix with perfect circle * Actually fix rotated gradient * Gradient transform & fix on rotated canvas * Cleanup & remove logging * Add properties panel entries for artboards (#572) * Artboards can have properties * fix crash when renaming artboards * moved target document to utility types * moved import and added test for file version information * fixed missing import * fix error from merging * - typed properties message handler data - removed name from WidgetRow * clippy warnings * artboards have seperate properties section * - color input can be forced to have selection - crop tool shows on switch - select tool shows on switch * variable renamed * change to use PropType<boolean> instead of PropType<Boolean> * Add an artboard icon * Add the "Delete Artboard" hint * fix unselect glitch * even better * Remove the Transform properties group Co-authored-by: Keavon Chambers <keavon@keavon.com> * Bug Fix: boolean union on multiple shapes * Font selection for text layers (#585) * Add font dropdown * Add fonts * Font tool options * Fix tests * Replace http with https * Add variant selection * Do not embed default font * Use proxied font list API * Change default font to Merriweather * Remove outdated comment * Specify font once & load font into foreignobject * Fix tests * Rename variant to font_style * Change TextAreaInput to use FieldInput (WIP, breaks functionality) * Fix textarea functionality * Fix types * Add weight name mapping * Change labeling of "Italic" * Remove commented HTML node * Rename font "name" to "font_family" and "file" "font_file" * Fix errors * Fix fmt Co-authored-by: Keavon Chambers <keavon@keavon.com> * Improvements to the layer transform cage UX (#589) * Allow input system to handle mousedown while dragging * Fix abort * Add apsect ratio * Make comment more explicit * Fix abort when dragging * Constrain when dragging edge * Rename Crop tool to Artboard tool * Stop pointerdown event from properties panel (#600) * Change stroke weight from ints to floats (#601) Also rename stroke "width" to "weight" in some places. Closes #587 * Change stroke weight from ints to floats * "miter_limit" -> "line_join_miter_limit" * Bump file format version * cargo update Prevent iterating beyond list bounds * Bug fix: proper composite intersection behavior * fix warnings * Improved ray casting and common intersection cases Finding intersections near path segment endpoints was previously unreliable because of imprecision, and the necessity of avoiding double counting any intersections. And, because of snapping, intersections on the endpoints of path segments are a common case. This also improved the ray casting use case, which previously used a "fudge factor" to mitigate the common problem of casting a ray into line endpoints. * fixed warnings * Fix properties deselect (#606) * Fix properties panel deselect * Fix arrow cursors on select tool * Fix drag from UI to document causing mouse down * Fix tests * Cleanup * cleanup messages * Draw the outlines of shapes on hover and selection (#609) * Add hover outline overlay * Increase selection tolerance * Increase weight * Only check if top intersection is selected * Outline selected paths * Reduce outline weight * Increase path tool outline thickness to match hover * Update to use unreachable! instead of panic! * Upgrade vue-cli to version 5 (#594) * Upgrade to Vue CLI 5 (fails to compile) * Upgrade versions with last few weeks of changes * Updated to fork-ts-checker-webpack-plugin 7.2.3 * Remove package.json overrides in lieu of the fixed fork-ts-checker-webpack-plugin@6.5.1 * Fix svg importing * Comments * For debugging only: added infrastructureLogging to vue.config.js * Now works on Windows, waiting on fork-ts-checker-webpack-plugin backport if possible * Switch to the fixed fork-ts-checker-webpack-plugin@6.5.2 * Fix license checker build compilation Co-authored-by: 0hypercube <0hypercube@gmail.com> * Tidy up the full frontend codebase and use optional chaining where possible (#620) * Tidy up the full frontend codebase and use optional chaining where possible * Code review changes * Add a hotkey to select a random primary color (#622) * Add shortcut to select a random primary color (#549) * Rename random primary color message and reduce the number of calls to generate_uuid * Add documentation for SelectRandomPrimaryColor message * Set the alpha value to 255 instead of a random value #622 Co-authored-by: Florent Collin <florentcollin23@gmail.com> * Move the Layer Tree panel's New Folder and Delete icons into the options bar * Migrate dialogs to Rust and add a New File dialog (#623) * Migrate coming soon and about dialog to Rust * Migrate confirm close and close all * Migrate dialog error * Improve keyboard navigation throughout UI * Cleanup and fix panic dialog * Reduce css spacing to better match old dialogs * Add new document modal * Fix crash when generating default name * Populate rust about graphite data on startup * Code review changes * Move one more :focus CSS rule into App.vue * Add a dialog message and move dialogs * Split out keyboard input navigation from this branch * Improvements including simplifying panic dialog code Co-authored-by: Keavon Chambers <keavon@keavon.com> * Snapping system improvements and refactor (#621) * Snap to points and refactor * Improve dot position on bounds * Add snap matrix * Cleanup * Code review * Half axis fade rather than increase it * Fix fmt * Hide snap to point overlay when active Co-authored-by: Keavon Chambers <keavon@keavon.com> * Add the File > Export dialog and PNG/JPG downloading (#629) * Add export dialog * Code review changes * More code review feedback * Fix compilation on stable Rust * Fixes to problems Co-authored-by: Keavon Chambers <keavon@keavon.com> * Code review Co-authored-by: Keavon Chambers <keavon@keavon.com> Co-authored-by: Oliver Davies <oliver@psyfer.io> Co-authored-by: mfish33 <32677537+mfish33@users.noreply.github.com> Co-authored-by: 0HyperCube <78500760+0HyperCube@users.noreply.github.com> Co-authored-by: TrueDoctor <dennis@kobert.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alaska <simon.wuelker@arcor.de> Co-authored-by: 0hypercube <0hypercube@gmail.com> Co-authored-by: FlorentCollin <florentcollinpro@gmail.com> Co-authored-by: Florent Collin <florentcollin23@gmail.com>

* Add embedable bitmaps * Initial work on blob urls * Finish implementing data url * Fix some bugs * Rename bitmap to image * Fix loading image on document load * Add transform properties for image * Remove some logging * Add image dimensions * Implement system copy and paste * Fix pasting images * Fix test * Address code review Co-authored-by: Keavon Chambers <keavon@keavon.com>

@caleb-ad

* changed path_intersection structure * comment * Removed do_if! * Create project website with near-complete home page * Added support for undoing - i gotta say the undo system is quite nice * Website responsive resizing improvements * Add newsletter signup to website * Pen tool fixes (#563) Resolves 3 known bugs with the pen tool. * Fixed crash pointed out by @caleb-ad * Fixed issue with final path segment losing handle data * Replace curves with lines when under a drag threshold, improves usability. * Readability improvements, improved comments * Color Input (#565) * initial working prototype * clean up component * Fix alignment * Code review tweaks Co-authored-by: Keavon Chambers <keavon@keavon.com> * Made the non-inclusive end of a pathseg less inclusive Fixed Bug: When doing a closepath it is possible that the current and beginning edge are both None Fixed Numerous other things * changed how closepath works modified how overlapping_curve_intersections is working * Add "New Folder"/"Delete Selected" buttons to layer panel Closes #532 * Update npm dependencies * Set text color based on its fill when it's being edited * Reorder tool icons, update favicon and logo, and other icon cleanup * Bug Fix: Line-Line intersect origin wasn't being preserved * Bug Fix: proper assignment of t_values in overlapping_curve_intersections * Honestly, i don't even know what I was thinking when i wrote the logic for splitting a subcurve at endpoints, but it was wrong. * Feature: overlapping rectangles behave properly, (except when intersections aren't found correctly) * Remake node type icons (closes #483); color picker cleanup * Change tool shelf icon colors to use classes not style * Add Image node icon and rename node from Path to Shape * Bug Fix: proper intersection construction in partial overlap case * cleaned up log statements * Add website revisions and many new pages * Add features page and fixes to website * Fix clippy lints and update packages (#568) * Fix type error in Brave browser (#569) * Small website text improvements * Various website fixes * Adjusted constants Rearranged intersection algorithm * Changed BooleanOperation::SubtractBack to use SubtractFront Added composite_boolean_operation for operations with more than one shape * Add node graph mockup to website * Differentiate between scale and dimensions (#570) * Differentiate between scale and dimensions * Fix layout and naming of properties * Add embedable images (#564) * Add embedable bitmaps * Initial work on blob urls * Finish implementing data url * Fix some bugs * Rename bitmap to image * Fix loading image on document load * Add transform properties for image * Remove some logging * Add image dimensions * Implement system copy and paste * Fix pasting images * Fix test * Address code review Co-authored-by: Keavon Chambers <keavon@keavon.com> * Bump minimist from 1.2.5 to 1.2.6 in /frontend (#571) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix panic dialogue when handling a message (#573) * Fix panic dialogue when handling a message * Fix indents for github reporting * More whitespace improvements * Save: line_intersection * Add documentation to many parts of the Rust codebase (#552) * add lots of doccomments * add conversion traits from layerdatatypes to layers * add suggested doc improvements * Code review changes Co-authored-by: Keavon Chambers <keavon@keavon.com> * Add additional stroke properties (#582) * Add aditional stroke properties * Add comment explaining clones for closure * Improve labels * Fix doc test Co-authored-by: Keavon Chambers <keavon@keavon.com> * Bug Fix: .y not .x * Expand upon the "Announcing Graphite alpha" blog post * All shapes now have a Fill in the properties panel; color inputs are now optional (#583) * Add aditional stroke properties * Make the colour input optional * Fix fmt * Apply code review changes * Code review nitpicks * Fix recursion Co-authored-by: Keavon Chambers <keavon@keavon.com> * New blog post: "Distributed computing with the Graphene runtime" * Fix gradient transformation (#588) * Fix with perfect circle * Actually fix rotated gradient * Gradient transform & fix on rotated canvas * Cleanup & remove logging * Add properties panel entries for artboards (#572) * Artboards can have properties * fix crash when renaming artboards * moved target document to utility types * moved import and added test for file version information * fixed missing import * fix error from merging * - typed properties message handler data - removed name from WidgetRow * clippy warnings * artboards have seperate properties section * - color input can be forced to have selection - crop tool shows on switch - select tool shows on switch * variable renamed * change to use PropType<boolean> instead of PropType<Boolean> * Add an artboard icon * Add the "Delete Artboard" hint * fix unselect glitch * even better * Remove the Transform properties group Co-authored-by: Keavon Chambers <keavon@keavon.com> * Bug Fix: boolean union on multiple shapes * Font selection for text layers (#585) * Add font dropdown * Add fonts * Font tool options * Fix tests * Replace http with https * Add variant selection * Do not embed default font * Use proxied font list API * Change default font to Merriweather * Remove outdated comment * Specify font once & load font into foreignobject * Fix tests * Rename variant to font_style * Change TextAreaInput to use FieldInput (WIP, breaks functionality) * Fix textarea functionality * Fix types * Add weight name mapping * Change labeling of "Italic" * Remove commented HTML node * Rename font "name" to "font_family" and "file" "font_file" * Fix errors * Fix fmt Co-authored-by: Keavon Chambers <keavon@keavon.com> * Improvements to the layer transform cage UX (#589) * Allow input system to handle mousedown while dragging * Fix abort * Add apsect ratio * Make comment more explicit * Fix abort when dragging * Constrain when dragging edge * Rename Crop tool to Artboard tool * Stop pointerdown event from properties panel (#600) * Change stroke weight from ints to floats (#601) Also rename stroke "width" to "weight" in some places. Closes #587 * Change stroke weight from ints to floats * "miter_limit" -> "line_join_miter_limit" * Bump file format version * cargo update Prevent iterating beyond list bounds * Bug fix: proper composite intersection behavior * fix warnings * Improved ray casting and common intersection cases Finding intersections near path segment endpoints was previously unreliable because of imprecision, and the necessity of avoiding double counting any intersections. And, because of snapping, intersections on the endpoints of path segments are a common case. This also improved the ray casting use case, which previously used a "fudge factor" to mitigate the common problem of casting a ray into line endpoints. * fixed warnings * Fix properties deselect (#606) * Fix properties panel deselect * Fix arrow cursors on select tool * Fix drag from UI to document causing mouse down * Fix tests * Cleanup * cleanup messages * Draw the outlines of shapes on hover and selection (#609) * Add hover outline overlay * Increase selection tolerance * Increase weight * Only check if top intersection is selected * Outline selected paths * Reduce outline weight * Increase path tool outline thickness to match hover * Update to use unreachable! instead of panic! * Upgrade vue-cli to version 5 (#594) * Upgrade to Vue CLI 5 (fails to compile) * Upgrade versions with last few weeks of changes * Updated to fork-ts-checker-webpack-plugin 7.2.3 * Remove package.json overrides in lieu of the fixed fork-ts-checker-webpack-plugin@6.5.1 * Fix svg importing * Comments * For debugging only: added infrastructureLogging to vue.config.js * Now works on Windows, waiting on fork-ts-checker-webpack-plugin backport if possible * Switch to the fixed fork-ts-checker-webpack-plugin@6.5.2 * Fix license checker build compilation Co-authored-by: 0hypercube <0hypercube@gmail.com> * Tidy up the full frontend codebase and use optional chaining where possible (#620) * Tidy up the full frontend codebase and use optional chaining where possible * Code review changes * Add a hotkey to select a random primary color (#622) * Add shortcut to select a random primary color (#549) * Rename random primary color message and reduce the number of calls to generate_uuid * Add documentation for SelectRandomPrimaryColor message * Set the alpha value to 255 instead of a random value #622 Co-authored-by: Florent Collin <florentcollin23@gmail.com> * Move the Layer Tree panel's New Folder and Delete icons into the options bar * Migrate dialogs to Rust and add a New File dialog (#623) * Migrate coming soon and about dialog to Rust * Migrate confirm close and close all * Migrate dialog error * Improve keyboard navigation throughout UI * Cleanup and fix panic dialog * Reduce css spacing to better match old dialogs * Add new document modal * Fix crash when generating default name * Populate rust about graphite data on startup * Code review changes * Move one more :focus CSS rule into App.vue * Add a dialog message and move dialogs * Split out keyboard input navigation from this branch * Improvements including simplifying panic dialog code Co-authored-by: Keavon Chambers <keavon@keavon.com> * Snapping system improvements and refactor (#621) * Snap to points and refactor * Improve dot position on bounds * Add snap matrix * Cleanup * Code review * Half axis fade rather than increase it * Fix fmt * Hide snap to point overlay when active Co-authored-by: Keavon Chambers <keavon@keavon.com> * Add the File > Export dialog and PNG/JPG downloading (#629) * Add export dialog * Code review changes * More code review feedback * Fix compilation on stable Rust * Fixes to problems Co-authored-by: Keavon Chambers <keavon@keavon.com> * Code review Co-authored-by: Keavon Chambers <keavon@keavon.com> Co-authored-by: Oliver Davies <oliver@psyfer.io> Co-authored-by: mfish33 <32677537+mfish33@users.noreply.github.com> Co-authored-by: 0HyperCube <78500760+0HyperCube@users.noreply.github.com> Co-authored-by: TrueDoctor <dennis@kobert.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alaska <simon.wuelker@arcor.de> Co-authored-by: 0hypercube <0hypercube@gmail.com> Co-authored-by: FlorentCollin <florentcollinpro@gmail.com> Co-authored-by: Florent Collin <florentcollin23@gmail.com>

* Add embedable bitmaps * Initial work on blob urls * Finish implementing data url * Fix some bugs * Rename bitmap to image * Fix loading image on document load * Add transform properties for image * Remove some logging * Add image dimensions * Implement system copy and paste * Fix pasting images * Fix test * Address code review Co-authored-by: Keavon Chambers <keavon@keavon.com>

@caleb-ad

* changed path_intersection structure * comment * Removed do_if! * Create project website with near-complete home page * Added support for undoing - i gotta say the undo system is quite nice * Website responsive resizing improvements * Add newsletter signup to website * Pen tool fixes (#563) Resolves 3 known bugs with the pen tool. * Fixed crash pointed out by @caleb-ad * Fixed issue with final path segment losing handle data * Replace curves with lines when under a drag threshold, improves usability. * Readability improvements, improved comments * Color Input (#565) * initial working prototype * clean up component * Fix alignment * Code review tweaks Co-authored-by: Keavon Chambers <keavon@keavon.com> * Made the non-inclusive end of a pathseg less inclusive Fixed Bug: When doing a closepath it is possible that the current and beginning edge are both None Fixed Numerous other things * changed how closepath works modified how overlapping_curve_intersections is working * Add "New Folder"/"Delete Selected" buttons to layer panel Closes #532 * Update npm dependencies * Set text color based on its fill when it's being edited * Reorder tool icons, update favicon and logo, and other icon cleanup * Bug Fix: Line-Line intersect origin wasn't being preserved * Bug Fix: proper assignment of t_values in overlapping_curve_intersections * Honestly, i don't even know what I was thinking when i wrote the logic for splitting a subcurve at endpoints, but it was wrong. * Feature: overlapping rectangles behave properly, (except when intersections aren't found correctly) * Remake node type icons (closes #483); color picker cleanup * Change tool shelf icon colors to use classes not style * Add Image node icon and rename node from Path to Shape * Bug Fix: proper intersection construction in partial overlap case * cleaned up log statements * Add website revisions and many new pages * Add features page and fixes to website * Fix clippy lints and update packages (#568) * Fix type error in Brave browser (#569) * Small website text improvements * Various website fixes * Adjusted constants Rearranged intersection algorithm * Changed BooleanOperation::SubtractBack to use SubtractFront Added composite_boolean_operation for operations with more than one shape * Add node graph mockup to website * Differentiate between scale and dimensions (#570) * Differentiate between scale and dimensions * Fix layout and naming of properties * Add embedable images (#564) * Add embedable bitmaps * Initial work on blob urls * Finish implementing data url * Fix some bugs * Rename bitmap to image * Fix loading image on document load * Add transform properties for image * Remove some logging * Add image dimensions * Implement system copy and paste * Fix pasting images * Fix test * Address code review Co-authored-by: Keavon Chambers <keavon@keavon.com> * Bump minimist from 1.2.5 to 1.2.6 in /frontend (#571) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix panic dialogue when handling a message (#573) * Fix panic dialogue when handling a message * Fix indents for github reporting * More whitespace improvements * Save: line_intersection * Add documentation to many parts of the Rust codebase (#552) * add lots of doccomments * add conversion traits from layerdatatypes to layers * add suggested doc improvements * Code review changes Co-authored-by: Keavon Chambers <keavon@keavon.com> * Add additional stroke properties (#582) * Add aditional stroke properties * Add comment explaining clones for closure * Improve labels * Fix doc test Co-authored-by: Keavon Chambers <keavon@keavon.com> * Bug Fix: .y not .x * Expand upon the "Announcing Graphite alpha" blog post * All shapes now have a Fill in the properties panel; color inputs are now optional (#583) * Add aditional stroke properties * Make the colour input optional * Fix fmt * Apply code review changes * Code review nitpicks * Fix recursion Co-authored-by: Keavon Chambers <keavon@keavon.com> * New blog post: "Distributed computing with the Graphene runtime" * Fix gradient transformation (#588) * Fix with perfect circle * Actually fix rotated gradient * Gradient transform & fix on rotated canvas * Cleanup & remove logging * Add properties panel entries for artboards (#572) * Artboards can have properties * fix crash when renaming artboards * moved target document to utility types * moved import and added test for file version information * fixed missing import * fix error from merging * - typed properties message handler data - removed name from WidgetRow * clippy warnings * artboards have seperate properties section * - color input can be forced to have selection - crop tool shows on switch - select tool shows on switch * variable renamed * change to use PropType<boolean> instead of PropType<Boolean> * Add an artboard icon * Add the "Delete Artboard" hint * fix unselect glitch * even better * Remove the Transform properties group Co-authored-by: Keavon Chambers <keavon@keavon.com> * Bug Fix: boolean union on multiple shapes * Font selection for text layers (#585) * Add font dropdown * Add fonts * Font tool options * Fix tests * Replace http with https * Add variant selection * Do not embed default font * Use proxied font list API * Change default font to Merriweather * Remove outdated comment * Specify font once & load font into foreignobject * Fix tests * Rename variant to font_style * Change TextAreaInput to use FieldInput (WIP, breaks functionality) * Fix textarea functionality * Fix types * Add weight name mapping * Change labeling of "Italic" * Remove commented HTML node * Rename font "name" to "font_family" and "file" "font_file" * Fix errors * Fix fmt Co-authored-by: Keavon Chambers <keavon@keavon.com> * Improvements to the layer transform cage UX (#589) * Allow input system to handle mousedown while dragging * Fix abort * Add apsect ratio * Make comment more explicit * Fix abort when dragging * Constrain when dragging edge * Rename Crop tool to Artboard tool * Stop pointerdown event from properties panel (#600) * Change stroke weight from ints to floats (#601) Also rename stroke "width" to "weight" in some places. Closes #587 * Change stroke weight from ints to floats * "miter_limit" -> "line_join_miter_limit" * Bump file format version * cargo update Prevent iterating beyond list bounds * Bug fix: proper composite intersection behavior * fix warnings * Improved ray casting and common intersection cases Finding intersections near path segment endpoints was previously unreliable because of imprecision, and the necessity of avoiding double counting any intersections. And, because of snapping, intersections on the endpoints of path segments are a common case. This also improved the ray casting use case, which previously used a "fudge factor" to mitigate the common problem of casting a ray into line endpoints. * fixed warnings * Fix properties deselect (#606) * Fix properties panel deselect * Fix arrow cursors on select tool * Fix drag from UI to document causing mouse down * Fix tests * Cleanup * cleanup messages * Draw the outlines of shapes on hover and selection (#609) * Add hover outline overlay * Increase selection tolerance * Increase weight * Only check if top intersection is selected * Outline selected paths * Reduce outline weight * Increase path tool outline thickness to match hover * Update to use unreachable! instead of panic! * Upgrade vue-cli to version 5 (#594) * Upgrade to Vue CLI 5 (fails to compile) * Upgrade versions with last few weeks of changes * Updated to fork-ts-checker-webpack-plugin 7.2.3 * Remove package.json overrides in lieu of the fixed fork-ts-checker-webpack-plugin@6.5.1 * Fix svg importing * Comments * For debugging only: added infrastructureLogging to vue.config.js * Now works on Windows, waiting on fork-ts-checker-webpack-plugin backport if possible * Switch to the fixed fork-ts-checker-webpack-plugin@6.5.2 * Fix license checker build compilation Co-authored-by: 0hypercube <0hypercube@gmail.com> * Tidy up the full frontend codebase and use optional chaining where possible (#620) * Tidy up the full frontend codebase and use optional chaining where possible * Code review changes * Add a hotkey to select a random primary color (#622) * Add shortcut to select a random primary color (#549) * Rename random primary color message and reduce the number of calls to generate_uuid * Add documentation for SelectRandomPrimaryColor message * Set the alpha value to 255 instead of a random value #622 Co-authored-by: Florent Collin <florentcollin23@gmail.com> * Move the Layer Tree panel's New Folder and Delete icons into the options bar * Migrate dialogs to Rust and add a New File dialog (#623) * Migrate coming soon and about dialog to Rust * Migrate confirm close and close all * Migrate dialog error * Improve keyboard navigation throughout UI * Cleanup and fix panic dialog * Reduce css spacing to better match old dialogs * Add new document modal * Fix crash when generating default name * Populate rust about graphite data on startup * Code review changes * Move one more :focus CSS rule into App.vue * Add a dialog message and move dialogs * Split out keyboard input navigation from this branch * Improvements including simplifying panic dialog code Co-authored-by: Keavon Chambers <keavon@keavon.com> * Snapping system improvements and refactor (#621) * Snap to points and refactor * Improve dot position on bounds * Add snap matrix * Cleanup * Code review * Half axis fade rather than increase it * Fix fmt * Hide snap to point overlay when active Co-authored-by: Keavon Chambers <keavon@keavon.com> * Add the File > Export dialog and PNG/JPG downloading (#629) * Add export dialog * Code review changes * More code review feedback * Fix compilation on stable Rust * Fixes to problems Co-authored-by: Keavon Chambers <keavon@keavon.com> * Code review Co-authored-by: Keavon Chambers <keavon@keavon.com> Co-authored-by: Oliver Davies <oliver@psyfer.io> Co-authored-by: mfish33 <32677537+mfish33@users.noreply.github.com> Co-authored-by: 0HyperCube <78500760+0HyperCube@users.noreply.github.com> Co-authored-by: TrueDoctor <dennis@kobert.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alaska <simon.wuelker@arcor.de> Co-authored-by: 0hypercube <0hypercube@gmail.com> Co-authored-by: FlorentCollin <florentcollinpro@gmail.com> Co-authored-by: Florent Collin <florentcollin23@gmail.com>

Add embedable bitmaps

added85

0HyperCube and others added 5 commits March 12, 2022 19:02

Merge branch 'master' into bitmap-images

a1c00ee

Initial work on blob urls

8f3cb14

Finish implementing data url

bb8fc4d

Fix some bugs

fa3fc22

Rename bitmap to image

0bdf991

0HyperCube changed the title ~~Add embedable bitmaps~~ Add embedable images Mar 13, 2022

0HyperCube added 5 commits March 14, 2022 20:35

Fix loading image on document load

ea33bea

Add transform properties for image

70ffa28

Remove some logging

510687c

Add image dimensions

bb53b05

Implement system copy and paste

91068d2

0HyperCube marked this pull request as ready for review March 15, 2022 22:08

Keavon force-pushed the master branch 2 times, most recently from da64b61 to cc1c31d Compare March 17, 2022 09:51

Fix pasting images

230a128

Merge branch 'master' into bitmap-images

f4436c4

0HyperCube and others added 2 commits March 24, 2022 18:26

Fix test

6debcc7

Merge branch 'master' into bitmap-images

57d5145

Keavon approved these changes Mar 27, 2022

View reviewed changes

0HyperCube and others added 2 commits March 27, 2022 11:23

Address code review

790154d

Merge branch 'master' into bitmap-images

b480138

0HyperCube merged commit 332ed06 into master Mar 27, 2022

0HyperCube deleted the bitmap-images branch March 27, 2022 10:43

Uh oh!

Conversation

0HyperCube commented Feb 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Keavon commented Feb 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Feb 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Pages

Uh oh!

Keavon commented Mar 5, 2022

Uh oh!

Keavon commented Mar 6, 2022

Uh oh!

Keavon commented Mar 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0HyperCube commented Mar 21, 2022

Uh oh!

Keavon commented Mar 21, 2022

Uh oh!

0HyperCube commented Mar 24, 2022

Uh oh!

Keavon left a comment

Choose a reason for hiding this comment

Uh oh!

Keavon Mar 27, 2022

Choose a reason for hiding this comment

Uh oh!

0HyperCube Mar 27, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

0HyperCube commented Feb 21, 2022 •

edited

Loading

Keavon commented Feb 21, 2022 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 21, 2022 •

edited

Loading

Keavon commented Mar 16, 2022 •

edited

Loading