Refactor shape gizmo interactivity to support future shape tools #2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
approved these changes
Jun 27, 2025
urisinger
pushed a commit
to urisinger/Graphite
that referenced
this pull request
Jul 15, 2025
…phiteEditor#2748) * impl GizmoHandlerTrait,Gizmo-manager and add comments * Code review --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR of #2683, and this fixes the two bugs mentioned by @Keavon in that.
ShapeGizmoHandler trait
Provides a common interface for shape-specific interactive gizmos (e.g., Star, Polygon).
Defines methods for handling state updates, clicks, dragging, overlays, and cleanup.
ShapeGizmoHandlers enum
Enum wrapper that abstracts over concrete shape gizmo types.
GizmoManager struct
Central controller that detects active gizmo layers, handles hover/click/drag input, and manages rendering.
Groups selected layers by shape type and activates the correct gizmo when hovered.