-
-
Notifications
You must be signed in to change notification settings - Fork 614
GPU invert node #2690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Firestar99
wants to merge
10
commits into
pre-texture-removal
Choose a base branch
from
gpu-invert
base: pre-texture-removal
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
GPU invert node #2690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linker is erroring due to the wasm-specific flags somehow ending up in a native compile, probably env leaking again. Doesn't trigger locally, likely due to me using the mold linker. Will play around with it a bit more tomorrow. |
9f02593
to
271eb33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code below shows how much I had to change the gpu invert node. Most of the changes are due to not wanting to depend on
gcore
, as it currently doesn't compile forno_std
. I think we could probably get away without changing it at all.Graphite/node-graph/gcore-shader/src/gpu_invert.rs
Lines 4 to 23 in bf26734
The rust-gpu shader calling it:
Graphite/node-graph/gcore-shader/src/gpu_invert.rs
Lines 33 to 38 in bf26734