-
-
Notifications
You must be signed in to change notification settings - Fork 614
Spacing type radio button for repeat and circular repeat node #2674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Spacing type radio button for repeat and circular repeat node #2674
Conversation
!build |
|
Finally got to code review, sorry it's taken a while. I was busy doing a sizable refactor to how the vector nodes handle their repeat transforms. This affected the two nodes you've worked on here, so I just synced up your branch and resolved the merge conflicts. However, I commented out the Circular Repeat changes which require a bit more thought to get working, and I hope you can take it from here after the following feedback which pertains to my observations before I synced with master using the build link, as you left the code last, in the comment above. Repeat node:
Circular Repeat node:
Other notes:
Thank you, and it's nice to see this coming along! |
Macros split into their own PR: #2706 |
Closes #2551
Spacing
radio parameter toRepeat
node, containingSpan
,Envelope
,Pitch
, andGap
options for spacing. See issue for how they must be spaced.Angle Pitch
float parameter andSpacing
radio parameter forCircular Repeat
node. TheSpan
option uses the calculations which already existed, thePitch
option rotates the next instance around the radius of the imaginary circle according to theAngle Pitch
parameter and places the shape there.unit
macro attribute. Givenstring
parameter is displayed as a unit type for the parameter.step
macro attribute. Given integer parameter is used as the step value for the parameter (ex. the arrow buttons on a number input increment/decrement bystep
amount).display_decimal_places
macro attribute. Given positive integer parameter is used to know how many decimal places to display for the number input if they are not 0.Usage for macros: