Skip to content

Add molding segments to the Path tool #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

4adex
Copy link
Collaborator

@4adex 4adex commented May 21, 2025

Part of #1870:

Closes #615.

@4adex 4adex changed the title Moulding of cubic bezier Molding Segments with Path Tool May 21, 2025
@4adex 4adex marked this pull request as ready for review May 23, 2025 19:44
@Keavon
Copy link
Member

Keavon commented May 24, 2025

!build

@Keavon Keavon changed the title Molding Segments with Path Tool Add molding segments to the Path tool May 24, 2025
Copy link

📦 Build Complete for 81bfca4
https://f7febd05.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented May 26, 2025

  • Right-click and Escape need to work to cancel molding
  • Alt should temporarily break colinearity and mold only the dragged segment, while also snapping the handles back to where they began before the molding drag began
  • C should permanently toggle colinearity on the two adjacent anchors, without snapping the handles back like above (be sure to handle the case where they're each initially of opposite state)
  • Hints should be updated for all of the above
  • We can merge this but then move onto finding a better algorithm that suits our desired molding behavior better
  • Please don't put any new code into Bezier-rs, find somewhere reasonable in the editor code to put that. Thanks.

@Keavon Keavon marked this pull request as draft May 26, 2025 04:03
@4adex 4adex marked this pull request as ready for review May 27, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sculpting / molding segments with the Path tool
2 participants