Skip to content

Add overlays for free-floating anchors on hovered/selected vector layers #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

seam0s-dev
Copy link
Contributor

Support for overlays as requested in #2558.

@seam0s-dev
Copy link
Contributor Author

Test cases:
free-floating anchors.graphite.txt

@seam0s-dev seam0s-dev marked this pull request as ready for review May 5, 2025 11:11
@seam0s-dev seam0s-dev closed this May 6, 2025
@seam0s-dev seam0s-dev reopened this May 6, 2025
@seam0s-dev seam0s-dev marked this pull request as draft May 6, 2025 08:47
@seam0s-dev seam0s-dev marked this pull request as ready for review May 9, 2025 06:49
@Keavon Keavon changed the title Add overlays for free-floating anchors for hovered/selected vector layers Add overlays for free-floating anchors on hovered/selected vector layers May 9, 2025
@Keavon
Copy link
Member

Keavon commented May 9, 2025

!build

Copy link

github-actions bot commented May 9, 2025

📦 Build Complete for 96b5e17
https://5420499d.graphite.pages.dev

@seam0s-dev
Copy link
Contributor Author

@0HyperCube Ready for review.

Copy link
Member

@0HyperCube 0HyperCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work so far.

I'm not really sure of the choice of the ManipulatorGroup to represent a single unconnected point with no handles.

I would also request tests before merging.
I've not manually tested this either but presumably it works mostly OK?

@seam0s-dev seam0s-dev requested a review from 0HyperCube May 15, 2025 09:01
@seam0s-dev seam0s-dev marked this pull request as draft May 17, 2025 10:34
@seam0s-dev seam0s-dev marked this pull request as ready for review May 18, 2025 20:34
@Keavon
Copy link
Member

Keavon commented May 18, 2025

See Discord comments. Marking as draft for the moment. Please mark as ready for review again once solved. Thanks :)

@seam0s-dev seam0s-dev marked this pull request as draft May 19, 2025 06:11
@seam0s-dev seam0s-dev marked this pull request as ready for review May 20, 2025 20:37
@Keavon
Copy link
Member

Keavon commented May 24, 2025

!build

Copy link

📦 Build Complete for 8202c48
https://9a90f752.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented May 24, 2025

Could you please make it work so when hovering over a point, it shows the overlays for the layer geometry, as it also does when hovering over a segment or filled shape? It looks like clicking those points works, but they're invisible until you actually click because hovering doesn't show it.

I'm also observing a crash that is hard to reproduce. I'll keep trying to make it relicatable.

@seam0s-dev
Copy link
Contributor Author

seam0s-dev commented May 24, 2025

I didn't understand what you meant specifically. I assume you meant that when you hover over a free-floating point on a layer that every shape on that layer also gets outlined, correct? If so, that does seems to work on my test cases.

free_floating_points.mp4

Copy link
Contributor Author

@seam0s-dev seam0s-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seam0s-dev seam0s-dev force-pushed the 2558-free-floating-anchors-overlays branch from afe8075 to 139ac6f Compare May 28, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants