Fix virtual Postgres source_file URI backslash normalization on Windows (#1672)#1675
Open
raman118 wants to merge 1 commit into
Open
Fix virtual Postgres source_file URI backslash normalization on Windows (#1672)#1675raman118 wants to merge 1 commit into
raman118 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves issue #1672, where
introspect_postgres()produces invalidsource_fileURIs on Windows (e.g.,postgresql:\myhost\mydbinstead ofpostgresql:/myhost/mydb).Cause
In
graphify/pg_introspect.py, thevirtual_pathwas constructed usingpathlib.Path(f"postgresql://{host}/{dbname}"). On Windows, this instantiates aWindowsPathobject, which normalizes the path separators to backslashes (\). Because the path is a synthetic URI rather than a local file path, it should be OS-independent and retain forward slashes.Solution
pathlib.PurePosixPathto constructvirtual_path. SincePurePosixPathuses POSIX path semantics regardless of the host operating system, the path string uses forward slashes on all platforms.test_pg_introspect_uri_forward_slashesintests/test_pg_introspect.pyto assert that the generated virtual paths always contain forward slashes and no backslashes, even when run on Windows.graphify update .to rebuild the AST knowledge graph.