fix(ruby): emit inherits edge for class superclass#1535
Closed
Synvoya wants to merge 1 commit into
Closed
Conversation
`class Dog < Animal` exposes the base in the `superclass` field, but the inheritance handler in `_extract_generic` had branches for java/kotlin/c#/scala/cpp/php/swift/python and none for Ruby, so every Ruby `inherits` edge was silently dropped (contains/methods/calls unaffected). Add a Ruby branch that reads the `superclass` field, handling both a bare `constant` (`< Animal`) and a `scope_resolution` (`< Foo::Bar` -> Bar). Adds a subclass to the Ruby fixture and a regression test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
|
Merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Ruby extractor silently drops every class inheritance edge.
class Dog < Animalproducescontains/method/call edges but noinheritsedge.Root cause
Ruby exposes the base class in the
superclassfield:The inheritance handler in
_extract_generichas dedicated branches for java, kotlin, c#, scala, cpp, php, swift, and python — but none for Ruby, so thesuperclassfield is never read.Fix
Add a Ruby branch that reads the
superclassfield and emits aninheritsedge, handling both forms:class Dog < Animal->Animalclass Cat < M::Base(scope_resolution) ->BaseIt reuses the same synthesize-base-node-if-absent +
add_edgepattern as the other language branches.Verification
pytest tests/test_languages.py-> 268 passed, 13 skipped (existing Ruby tests unaffected).ruff check --config pyproject.toml-> clean.Before / after
class Dog < Animalcontainsinherits Dog->Animal