fix: use .codex config dir for codex platform#1160
Conversation
safishamsi
left a comment
safishamsi
left a comment
There was a problem hiding this comment.
The fix is correct — Codex's hook already writes to .codex/hooks.json, so the skill should also live under .codex/. The change propagates cleanly through install and uninstall because both resolve the path dynamically via _PLATFORM_CONFIG["codex"]["skill_dst"] — no hardcoded paths to update there.
However the PR is missing test updates and CI will fail. tests/test_install.py has four assertions that still reference .agents for the codex platform — all need to be updated to .codex:
- Line 11:
"codex": (".agents/skills/graphify/SKILL.md",),→.codex/... - Line 44:
assert (tmp_path / ".agents" / "skills" / "graphify" / "SKILL.md").exists()→.codex/... - Lines 90 and 93:
test_install_project_codex_writes_skill_and_agentsasserts the skill under.agents/
Note: the Amp and Antigravity tests that legitimately use .agents/ should NOT be changed — only the codex-specific assertions.
Add those four test fixes and this is good to merge.
|
Thanks for the quick review, @safishamsi You are completely right. I've just pushed a new commit updating those four test assertions to point to .codex/. While at it, I also noticed that the test_codex_subcommand_project_install_and_uninstall_are_project_scoped and test_uninstall_project_removes_project_skill_only tests were also asserting against the .agents path for the Codex platform, so I took the liberty of proactively updating those as well to prevent the CI from failing on them. The CI should be green now! Let me know if anything else is needed. |
#1154: scope numpy>=2.0 constraint to python_version>='3.13' only. numpy 1.26.4 ships no cp313 wheel so uv sync falls back to a source build requiring a C compiler. The marker avoids forcing numpy 2.x on 3.10-3.12 users who have working 1.x environments. #1160: codex platform skill now installs to .codex/skills/graphify/ instead of .agents/skills/graphify/. The hook already wrote to .codex/ so the skill destination was inconsistent. Propagates automatically through install/uninstall (both read _PLATFORM_CONFIG dynamically). Updated all codex-specific test assertions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Landed in f146be3. All codex test assertions updated (.agents → .codex). Applied via 3-way merge to avoid reverting the postgres feature that landed after your branch was cut. Thanks! |
2 participants
Fixes an issue where the skill was incorrectly being copied to .agents\ instead of .codex\ for the codex platform. This aligns with the _install_codex_hook\ which correctly uses .codex/hooks.json.