Pages datasources #6601
Open
Pages datasources #6601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artf
reviewed
Sep 12, 2025
packages/core/src/data_sources/model/ComponentWithCollectionsState.ts
Outdated
Show resolved
Hide resolved
| super(props, opt); | ||
|
|
||
| const hasDataResolver = this.getDataResolver(); | ||
| this.syncComponentsCollectionState(); |
There was a problem hiding this comment.
Don't we need to add this inside the condition below?
packages/core/test/specs/data_sources/model/data_collection/ComponentDataCollection.ts
Outdated
Show resolved
Hide resolved
packages/core/test/specs/dom_components/model/ComponentWrapper.ts
Outdated
Show resolved
Hide resolved
packages/core/test/specs/dom_components/model/ComponentWrapper.ts
Outdated
Show resolved
Hide resolved
artf
reviewed
Oct 1, 2025
Comment on lines
+48
to
+58
| protected listenToDataSource() { | ||
| const path = this.dataSourcePath; | ||
| if (!path) return; | ||
|
|
||
| const { em, collectionsStateMap } = this; | ||
| this.dataSourceWatcher = new DataResolverListener({ | ||
| em, | ||
| resolver: new DataVariable({ type: DataVariableType, path }, { em, collectionsStateMap }), | ||
| onUpdate: () => this.onDataSourceChange(), | ||
| }); | ||
| } |
There was a problem hiding this comment.
I think we should also ensure to clear (from listeners) the previous this.dataSourceWatcher when this changes
Comment on lines
+68
to
+70
| protected get dataSourceProps(): DataVariableProps | undefined { | ||
| return this.get('dataResolver'); | ||
| } |
There was a problem hiding this comment.
above you have getDataResolver(), maybe let's replace this one with get dataResolverProps()?!
| return this.get('dataResolver'); | ||
| } | ||
|
|
||
| protected get dataSourcePath(): string | undefined { |
Comment on lines
+107
to
+113
| dataListeners.push( | ||
| this.createListener(em, DataSourcesEvents.path, ({ path: eventPath }: { path: string }) => { | ||
| if (eventPath.startsWith(path)) { | ||
| this.onChange(); | ||
| } | ||
| }), | ||
| ); |
There was a problem hiding this comment.
Do you think we really need this? 🤔
I guess I understand the reason behind it but it seems it could trigger too many unnecessary checks. When we add data components, I'd expect them to be already listening to the exact paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.