Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add label to ButtonProps type definition #6066

Merged
merged 1 commit into from
Aug 20, 2024
Merged

add label to ButtonProps type definition #6066

merged 1 commit into from
Aug 20, 2024

Conversation

havijs
Copy link
Contributor

@havijs havijs commented Aug 20, 2024

The field label seems to be missing from ButtonProps type definition.

const editor = grapesjs.init({
  panels: {
    defaults: [
      {
        id: 'panel-switcher',
        el: '.panel__switcher',
        buttons: [{
            id: 'show-layers',
            active: true,
            label: 'Layers', // Object literal may only specify known properties, and 'label' does not exist in type 'ButtonProps'. 
            command: 'show-layers',
            togglable: false,
          }]
    }
}

@artf artf merged commit acc0923 into GrapesJS:dev Aug 20, 2024
2 checks passed
@artf
Copy link
Member

artf commented Aug 20, 2024

Thanks @havijs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants