development environment upgrades #6059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danstarns
commented
Aug 12, 2024
Comment on lines
+19
to
+50
| 'no-var': 'off', | ||
| 'prefer-const': 'off', | ||
| 'no-prototype-builtins': 'off', | ||
| 'no-useless-escape': 'off', | ||
| 'prefer-rest-params': 'off', | ||
| 'no-empty': 'off', | ||
| 'prefer-spread': 'off', | ||
| 'no-extra-boolean-cast': 'off', | ||
| 'no-unsafe-optional-chaining': 'off', | ||
| 'no-shadow-restricted-names': 'off', | ||
| 'no-cond-assign': 'off', | ||
| 'no-fallthrough': 'off', | ||
| 'no-sparse-arrays': 'off', | ||
| 'no-redeclare': 'off', | ||
| 'no-control-regex': 'off', | ||
| 'no-constant-condition': 'off', | ||
| 'no-misleading-character-class': 'off', | ||
| 'no-undef': 'off', | ||
| 'no-func-assign': 'off', | ||
| 'no-regex-spaces': 'off', | ||
| '@typescript-eslint/ban-ts-comment': 'off', | ||
| '@typescript-eslint/no-require-imports': 'off', | ||
| '@typescript-eslint/no-explicit-any': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| '@typescript-eslint/no-unused-expressions': 'off', | ||
| '@typescript-eslint/no-unnecessary-type-const': 'off', | ||
| '@typescript-eslint/no-empty-object-type': 'off', | ||
| '@typescript-eslint/no-unnecessary-type-constraint': 'off', | ||
| '@typescript-eslint/no-this-alias': 'off', | ||
| '@typescript-eslint/no-unsafe-function-type': 'off', | ||
| '@typescript-eslint/no-non-null-asserted-optional-chain': 'off', | ||
| '@typescript-eslint/no-wrapper-object-types': 'off', |
There was a problem hiding this comment.
Ideally, we don't want all these rules and just rely on the recommended, however, that requires mass code transformation to fulfill. Let's keep this PR mostly about config and then come back to blocks of rules and incrementally remove them.
danstarns
commented
Aug 17, 2024
danstarns
commented
Aug 17, 2024
danstarns
commented
Aug 17, 2024
danstarns
commented
Aug 17, 2024
danstarns
commented
Aug 17, 2024
danstarns
commented
Aug 17, 2024
| @@ -318,7 +315,7 @@ describe('GrapesJS', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| test('Adds a new storage and fetch correctly data from it', done => { | |||
| test.skip('Adds a new storage and fetch correctly data from it', async () => { | |||
There was a problem hiding this comment.
There is a problem when upgrading jest and jsdom where the editor.onReady function alongside some dom components aren't working the same. Given its just this and a few others, I feel happy to skip these in favour of scope and come back un unskip the cases.
danstarns
commented
Aug 17, 2024
| config.fromElement = true; | ||
| config.storageManager.type = storageId; | ||
| config.plugins = [pluginName]; | ||
| config.storageManager.autoload = 1; | ||
| const editor = grapesjs.init(config); | ||
| editor.onReady(() => { |
danstarns
commented
Aug 17, 2024
| let editor: Editor; | ||
| let wrapper: ComponentWrapper; | ||
| let el1: Component; | ||
| let el2: Component; | ||
| let el3: Component; | ||
|
|
||
| beforeEach(done => { | ||
| beforeEach(() => { |
danstarns
commented
Aug 17, 2024
| @@ -86,25 +86,22 @@ describe('GrapesJS', () => { | |||
| expect(editor.getStyle().length).toEqual(0); | |||
| }); | |||
|
|
|||
| test('Editor canvas baseCSS can be overwritten', done => { | |||
| test.skip('Editor canvas baseCSS can be overwritten', () => { | |||
danstarns
commented
Aug 17, 2024
| with: | ||
| node-version: '12.x' | ||
| node-version: '20.x' |
artf
approved these changes
Aug 20, 2024
Merged
This was referenced Sep 24, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am updating Node, Linting, Formatting, and Testing dependencies to be in line with long-term supported versions.
This PR is related to:
This PR focuses on enhancing the developer experience when working on the GrapesJS OSS repository. Given that the project has been solely maintained by one person over several years, it is bound to have areas needing improvement.
The work here includes: