Add CSS variables #5437
Merged
Add CSS variables #5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) runtime function so it can be used with css variables
artf
approved these changes
Oct 8, 2023
|
Awesome work @quentin-bettoum 🔥 |
2 tasks
This was referenced May 24, 2024
This was referenced Aug 27, 2024
This was referenced Sep 20, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add CSS variables as an alternative to SASS variables to customize GrapesJS.
I had to replace the use of SASS
lightenanddarkenas they cannot work with CSS variable since they are interpreted at compile-time.I used color-mix instead, but the percentage used in
lighten/darkenand incolor-mixdoesn't give the same result as explained here. From what I've seen, it doesn't seem to make a big difference, but we have to keep this in mind.I also took the opportunity to remove some SCSS variables that were not used anymore.