Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix style parsing bug for attributes containing colon #188

Merged
merged 3 commits into from
Aug 10, 2017

Conversation

vladflorescu
Copy link

Example:
parseStyle('background-image:url("https://blahblah.blah")')
=> { 'background-image': 'url("https' } // before commit
=> { 'background-image': 'url("https://blahblah.blah")' } // after commit

@artf
Copy link
Member

artf commented Aug 7, 2017

thanks @vladflorescu94 but can you provide a test case for this, please?
You'll find them here: https://github.com/artf/grapesjs/blob/dev/test/specs/parser/model/ParserHtml.js

@vladflorescu
Copy link
Author

You're welcome! I did

@artf artf merged commit 73794c8 into GrapesJS:dev Aug 10, 2017
@artf
Copy link
Member

artf commented Aug 10, 2017

Thanks @vladflorescu94

@lock
Copy link

lock bot commented Sep 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Sep 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants