Prevent error when there's no activeElement during undo/redo

[nojacko]

Our errors logs picked up a lot of "Cannot read property 'activeElement' of null" errors so I put in a check.

I did spot the comment above the function:

    /**
     * Detects if some input is focused (input elements, text components, etc.)
     * Used internally, for example, to avoid undo/redo in text editing mode
     * @return {Boolean}
     */

The function only seems to return true is tag isn't BODY which doesn't match the comments. Is this correct?

[artf]

Yes James, that was actually an intentional behaviour, if activeElement was different from Body, some editable component, inside the canvas, was selected. Actually I had other issues with this method and now I prefer to rely on em.isEditing, probably I'll replace it in Undo Manager in the next release and will see what to do with this method, for now I accept you PR as it's a good check in any way

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.