Update entity (state) & service model#211
Update entity (state) & service model#211GrandMoff100 merged 25 commits intoGrandMoff100:devfrom kpustelnik:dev
Conversation
kpustelnik
left a comment
There was a problem hiding this comment.
Adding few comments regarding things I've added
|
@GrandMoff100 I've replaced | with Union. Can you retest please? |
|
I've reworked the models in my sources as I've found the home assistant's internal class definitions. Will try to update the PR shortly. |
|
@GrandMoff100 Apologies for the delay. I've adjusted the models. They should be pretty accurate now btw as I was basing on the homeassistant source code |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #211 +/- ##
==========================================
+ Coverage 97.24% 97.72% +0.48%
==========================================
Files 25 25
Lines 1343 1629 +286
==========================================
+ Hits 1306 1592 +286
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@kpustelnik Yay! No worries. I'm moving right now so I haven't been able to sit down at my workstation and give this PR the attention it deserves. I've started working on it locally and resolved some of your comments in my local changes. I should be able to finish up, rebase them on top of your most recent commits and get this PR finished sometime this week after I finish moving in tomorrow. |
|
@GrandMoff100 Understandable. That's of course no problem; good luck with moving! BTW just like mentioned before - HA service api can accept not only |
|
Now the last thing left to do is address the |
|
@GrandMoff100 Tbh Id just remove the parameter and let users insert the target manually in the data. |
|
It'll be slightly less convenient for the users to double check what parameters each service supports but that's alright I suppose. It is easy to implement and it's a simple solution. |
|
There you go @kpustelnik. Finally merged! |
|
Tysm! @GrandMoff100 |
|
@GrandMoff100 Shall the HAApi version be bumped? This seems like a major change to the lib. Wondering whether you're waiting for something more |
|
Sure thing! I can definitely push out a new version |
Resolves #210