fixing errors with bug and new ui #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurspa
approved these changes
Nov 15, 2020
|
It's still a draft. :D Don't approve it yet |
|
This ended up being a mixed grab bag of fixes and the commit will be fixed in the squash, here is the recap:
|
arthurspa
approved these changes
Nov 16, 2020
GramAddict/core/interaction.py
Outdated
| FOLLOW_REGEX = "Follow|Follow Back" | ||
| UNFOLLOW_REGEX = "Following|Requested" | ||
| BUTTON_REGEX = "android.widget.Button" | ||
| FOLLOW_REGEX = "^Follow|^Follow Back" |
There was a problem hiding this comment.
Follow Back is unnecessary since Follow will already match it
There was a problem hiding this comment.
Fair - that was just how it was originally.
There was a problem hiding this comment.
I had a comment but is not critical. You can remove this in another future commit.
- The old method used an identifier that no longer exists (thanks IG) - The old method used unneeded logic to determine if it was a block dialog - The new method just looks for another unfollow button (technically TextView) and clicks it if it's there - Still does followup check for block dialog Tested using force_interact on a private account I followed.
- the original removal broke the regex for follow back - in breaking follow back, I realized we actually follow back? That doesn't make sense. The point of following and liking people is to gain followers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.