Skip to content

Подготовить flasher к релизу v0.1.6#1

Open
GradusXaker wants to merge 3 commits intomainfrom
gradus/release-sync-v0.1.6
Open

Подготовить flasher к релизу v0.1.6#1
GradusXaker wants to merge 3 commits intomainfrom
gradus/release-sync-v0.1.6

Conversation

@GradusXaker
Copy link
Copy Markdown
Owner

Что сделано

  • обновлена версия приложения до 0.1.6
  • синхронизированы release-ссылки, README и Windows-инструкции под v0.1.6
  • убран хардкод v0.1.5 из installer и windows-release workflow
  • добавлены release notes для v0.1.6

Зачем

Этот PR готовит m5-flasher к следующему циклу релизов после обновления firmware-ветки и устраняет хрупкое место в Windows-сборке, где имя installer было привязано к старой версии.

Проверка

  • ./.venv/bin/python -m compileall src

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39e570adda

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +50 to +51
$version = "${{ github.ref_name }}" -replace '^v', ''
Move-Item -Path "dist\GradusFlasher-Setup-v$version.exe" -Destination "GradusFlasher-Setup-${{ github.ref_name }}.exe"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use app version for installer source name

This rename logic now depends on github.ref_name, which is a branch name for workflow_dispatch runs (for example, main), so $version becomes main and Move-Item looks for dist\GradusFlasher-Setup-vmain.exe. The installer output is still version-based (OutputBaseFilename=GradusFlasher-Setup-v{#MyAppVersion} in windows-installer.iss), so manual workflow runs will fail at this step even though the installer was built successfully.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant