Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39e570adda
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $version = "${{ github.ref_name }}" -replace '^v', '' | ||
| Move-Item -Path "dist\GradusFlasher-Setup-v$version.exe" -Destination "GradusFlasher-Setup-${{ github.ref_name }}.exe" |
There was a problem hiding this comment.
Use app version for installer source name
This rename logic now depends on github.ref_name, which is a branch name for workflow_dispatch runs (for example, main), so $version becomes main and Move-Item looks for dist\GradusFlasher-Setup-vmain.exe. The installer output is still version-based (OutputBaseFilename=GradusFlasher-Setup-v{#MyAppVersion} in windows-installer.iss), so manual workflow runs will fail at this step even though the installer was built successfully.
Useful? React with 👍 / 👎.
Что сделано
0.1.6v0.1.6v0.1.5из installer иwindows-releaseworkflowv0.1.6Зачем
Этот PR готовит
m5-flasherк следующему циклу релизов после обновления firmware-ветки и устраняет хрупкое место в Windows-сборке, где имя installer было привязано к старой версии.Проверка
./.venv/bin/python -m compileall src