Move extensions of ShadowJar
#1566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dow-jar # Conflicts: # src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt
Goooler
force-pushed
the
g/20250802/custom-shadow-jar
branch
from
9d969b9 to
bd3b389
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves extension functions and constants related to ShadowJar from the ShadowJavaPlugin companion object to the ShadowJar companion object, improving code organization by keeping these utilities closer to the task they operate on.
- Moved
SHADOW_JAR_TASK_NAMEconstant andshadowJarextension property toShadowJarcompanion object - Moved
registerShadowJarCommonfunction toShadowJarcompanion object with signature changes - Updated all import statements across plugin and test files to reflect the new locations
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ShadowJar.kt | Added companion object with moved constants, extension properties, and utility functions |
| ShadowJavaPlugin.kt | Removed moved items from companion object and updated imports |
| ShadowKmpPlugin.kt | Updated import to use new location of registerShadowJarCommon |
| ShadowApplicationPlugin.kt | Updated import to use new location of shadowJar extension |
| RelocationTest.kt | Updated import to use new location of SHADOW_JAR_TASK_NAME |
| MinimizationTest.kt | Updated import to use new location of SHADOW_JAR_TASK_NAME |
| JavaPluginTest.kt | Updated import and fixed test classifier from "tests" to "test" |
| BasePluginTest.kt | Updated import to use new location of SHADOW_JAR_TASK_NAME |
| lint-baseline.xml | Updated line numbers due to code movement |
| custom-tasks/README.md | Updated documentation to use "test" classifier instead of "tests" |
| shadow.api | Updated API signature to reflect moved items |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.