Skip to content

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Jul 31, 2025

@Goooler Goooler force-pushed the g/20250731/dup-with-trans-test branch 2 times, most recently from 658fbfb to f557e93 Compare July 31, 2025 04:37
@Goooler Goooler force-pushed the g/20250731/dup-with-trans-test branch 2 times, most recently from 9e55db3 to 1865e85 Compare July 31, 2025 04:46
@Goooler Goooler marked this pull request as ready for review July 31, 2025 07:05
@Goooler Goooler changed the title Add more tests for DuplicatesStrategy Add more docs and tests for DuplicatesStrategy Jul 31, 2025
@Goooler Goooler requested a review from Copilot July 31, 2025 07:06

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Goooler Goooler force-pushed the g/20250731/dup-with-trans-test branch from d53e043 to 251d55d Compare July 31, 2025 07:15
@Goooler Goooler requested a review from Copilot July 31, 2025 07:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances documentation and test coverage for the DuplicatesStrategy functionality in ShadowJar tasks, following up on issue #1349. The changes improve clarity around how duplicate file handling works and provide comprehensive examples.

  • Adds detailed documentation for the getDuplicatesStrategy() method with examples of each strategy type
  • Adds functional tests demonstrating how to override the duplicates strategy using eachFile and filesMatching
  • Updates existing documentation to clarify interactions between ResourceTransformers and duplicatesStrategy

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ShadowJar.kt Adds comprehensive KDoc for getDuplicatesStrategy() method with strategy examples and transformer interaction notes
ServiceFileTransformerTest.kt Adds tests for overriding EXCLUDE strategy using eachFile and filesMatching, fixes line separator handling
ShadowJarCachingTest.kt Fixes test setup by using writeText instead of appendText to prevent accumulating configurations
merging/README.md Enhances documentation with clearer examples of strategy override techniques and additional reference links
shadow.api Updates API surface to include the newly documented getDuplicatesStrategy() method

@Goooler Goooler enabled auto-merge (squash) July 31, 2025 07:26
@Goooler Goooler disabled auto-merge July 31, 2025 07:26
@Goooler Goooler enabled auto-merge (squash) July 31, 2025 07:26
@Goooler Goooler merged commit ed6c1ba into main Jul 31, 2025
13 checks passed
@Goooler Goooler deleted the g/20250731/dup-with-trans-test branch July 31, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude a specific class from a dependency but it's the same name as a local one

2 participants