Don't re-add suppressed Gradle API to compileOnly configuration
#1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
reviewed
May 3, 2025
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/JavaPluginTest.kt
Show resolved
Hide resolved
Goooler
approved these changes
May 3, 2025
There was a problem hiding this comment.
LGTM!
I'll merge this after feedback from gradle/plugin-portal-requests#260.
|
Hell yeah |
…ppressed-gradle-api # Conflicts: # src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/JavaPluginTest.kt
This reverts commit 0cae38e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of Gradle's experiments with publishing an external Gradle API (gradle/gradle#29483), they are beginning to look at suppressing the local Gradle API dependency that is usually used when the
java-gradle-pluginplugin is applied. Because of this, though, the current strategy that the Shadow plugin uses to move it fromapitocompileOnlydoesn't check if it exists to begin with. This PR aims to solve that problem. I've added tests as needed.Gradle's Plugin Publish plugin has a similar issue which I've gone into detail in gradle/plugin-portal-requests#260.