Adjust property initializations and modifiers in ShadowJar
#1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
force-pushed
the
g/20241206/convention-in-shadow-jar
branch
from
84c6342 to
a384bd5
Compare
Goooler
commented
Dec 6, 2024
Comment on lines
-94
to
-99
| shadow.enableRelocation.convention(false) | ||
| shadow.minimizeJar.convention(false) | ||
| shadow.relocationPrefix.convention(ShadowBasePlugin.SHADOW) | ||
| shadow.dependencyFilter.convention(DefaultDependencyFilter(project)) | ||
| shadow.configurations.convention(listOf(project.runtimeConfiguration)) | ||
| shadow.includedDependencies.setFrom(shadow.dependencyFilter.map { it.resolve(shadow.configurations.get()) }) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (4)
- api/shadow.api: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowPluginSpec.groovy: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
Comments skipped due to low confidence (1)
src/docs/changes/README.md:9
- The phrase 'This fix the regression' should be corrected to 'This fixes the regression'.
This fix the regression for registering custom `ShadowJar` tasks.
Goooler
commented
Dec 6, 2024
There was a problem hiding this comment.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (4)
- api/shadow.api: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowPluginSpec.groovy: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
Comments skipped due to low confidence (1)
src/docs/changes/README.md:8
- The sentence should be 'This fixes the regression for registering custom
ShadowJartasks.'
- This fix the regression for registering custom `ShadowJar` tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #1074.