nmcp generates a maven repository for every publication which seems redundand

[vlsi]

Expected and Results

Ideally, the plugin should reuse a single repository, for instance centralPortal.

Currently, every publication generates its own repository:

nmcp/src/main/kotlin/nmcp/NmcpExtension.kt

Lines 25 to 33 in eb08cc3

	val capitalized = publicationName.capitalized()
	val publishing = project.extensions.findByType(PublishingExtension::class.java)!!
	val m2Dir = project.layout.buildDirectory.dir("nmcp/m2$capitalized")
	val repoName = "nmcp$capitalized"
	publishing.apply {
	repositories.apply {
	maven {
	it.name = repoName

There are several issues:

1. Repository name generates after publication name which is weird
2. Publication task names get publication name twice (because repositoryName is effectively a publication name)

For example:

Publishing tasks
----------------
...
publishMavenJavaPublicationToNmcpMavenJavaRepository - Publishes Maven publication 'mavenJava' to Maven repository 'nmcpMavenJava'.

Note NmcpMavenJavaRepository repeats publication name.

See also:

• Consider using publishing.repository for repository url and credentials #30

[martinbonnin]

I remember now why this is the case.

This is to avoid overlapping outputs. The first thing we do is delete all the contents of the local repository to avoid stale files. But if multiple publications publish to the same directory, that doesn't work anymore. This is clearly a hack and it's not great but I think this is unfortunately a required hack.

Moving forward, I'd like to investigate generating the files directly from the Publication instead of relying on maven-publish to do it. Probably not in the short term though...

[vlsi]

Got it now. It is worth documenting the reasons as code comments.

Wdyt of adding an explicit clean task which would clean the repo, and make the rest of the publish tasks depend on the clean one?

[martinbonnin]

Yes and yes! That would make the implementation a lot more explicit.

[martinbonnin]

PR to add a comment there: #75

After thinking a bit more about this, I'm not sold on creating a clean task. I usually like that each task has its own non-overlapping output. Deleting stale contents and and adding new contents should be an atomic thing (as in: happening in the same task). I'm closing this one, feel free to leave a message if you think there's more to be done.