Skip to content

fix(tokenizer): fix eos token id if it is a list #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2025
Merged

fix(tokenizer): fix eos token id if it is a list #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
578734b
fix(tokenizer): fix eos token id if it is a list
gufengc Nov 21, 2025
1806850
update
gufengc Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/parallax/server/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,7 @@ def _handle_input_requests(self, requests: List[Request]):
"next_token_id": req.next_token_id,
"rid": req.request_id,
}
if req.next_token_id == self.tokenizer.eos_token_id:
if original_req.status == RequestStatus.FINISHED_EOS:
req_dict["eos"] = True
if original_req.status == RequestStatus.FINISHED_MAX_LENGTH:
req_dict["length"] = True
Expand Down
5 changes: 4 additions & 1 deletion src/parallax/server/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,10 @@ def check_and_update_request_status(self, request: InitialRequest) -> bool:
last_token_id = request.output_ids[-1] if request.output_ids else None
if request.abort:
finished = True
if self.eos_token_id and last_token_id == self.eos_token_id:
if self.eos_token_id and (
last_token_id == self.eos_token_id
or (isinstance(self.eos_token_id, list) and last_token_id in self.eos_token_id)
):
request.update_status(RequestStatus.FINISHED_EOS)
finished = True
elif (
Expand Down