Skip to content
This repository was archived by the owner on Jul 23, 2024. It is now read-only.
This repository was archived by the owner on Jul 23, 2024. It is now read-only.

⚠️ Shell Engine Roadmap (see for list of bugs) #763

Open

Description

@tfuxu

Feature description

The list below shows features that needs to be implemented to make Shell Engine fully "feature-complete". Items in "Issues" list should be all checked out before 0.8.0 release.

Roadmap:

  • Add explanations for custom Shell colors
  • Implement panel theming
  • Theme export option (allow user to choose Shell version for which to generate the theme)
  • Automatic theme variant detection (implement after preset format redesign)
  • Revert to previous theme option (requires backup functionality implemented)
  • System-wide theming (required to theme lock screen and GDM)
  • Theme other colorable Shell assets

Issues:

  • Fix Quick Settings menu not being themed in GNOME 44
  • Fix date text color in Today's calendar widget using the same variable as foreground color for accent-colored elements
  • Fix icons in Quick Settings items not using foreground color for accent-colored elements
  • Adapt on-board keyboard to support custom themes

Additional Context

There is a Nightly Flatpak Repo available here for trying and reporting bugs of the upcoming Gradience version

Did you read the Code of Conduct?

Activity

  1. modified the milestone: 0.8.0 on May 4, 2023
  2. V-Mann-Nick commented on May 8, 2023

    @V-Mann-Nick

    Thank you very much for the awesome work. I'm already using the shell engine and it looks really great. I really only noticed one minor thing: the dropdown in the quick settings have default color.

    Screenshot

    image

  3. moved this from Todo to In Progress in Gradienceon May 8, 2023
  4. tfuxu commented on May 8, 2023

    @tfuxu
    MemberAuthor

    Thank you for your kind words! The issue you described here is the first item in issues list, I'll try to fix it as soon as I have some free time this week.

  5. V-Mann-Nick commented on May 9, 2023

    @V-Mann-Nick

    Perfect. Appreciate it a lot. Sorry for my redundant comment.

  6. 0xMRTT commented on May 14, 2023

    @0xMRTT
    Member

    Shell doesn't support @var_name so a function for converting each @var_name to the hex/rgb value is needed since @ vars are LibAdwaita only

  7. tfuxu commented on May 14, 2023

    @tfuxu
    MemberAuthor

    Shell doesn't support @var_name so a function for converting each @var_name to the hex/rgb value is needed since @ vars are LibAdwaita only

    Fixed in 1a5b1f4. We already have a function to handle that, it was just buggy.

  8. pinned this issue on Jul 10, 2023
  9. changed the title [-]Shell Engine Roadmap[/-] [+]Shell Engine Roadmap (bugs are listed here)[/+] on Jul 10, 2023
  10. 43 remaining items

  11. manan-gup commented on Dec 18, 2023

    @manan-gup
    Traceback (most recent call last):
      File "/app/lib/python3.11/site-packages/gradience/frontend/widgets/shell_theming_group.py", line 113, in on_apply_button_clicked
        user_themes_available = is_shell_ext_installed(ShellTheme().THEME_EXT_NAME)
                                                       ^^^^^^^^^^^^
      File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 59, in __init__
        self._detect_shell_version()
      File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 326, in _detect_shell_version
        raise UnsupportedShellVersion(
    gradience.backend.exceptions.UnsupportedShellVersion: GNOME Shell version 45 is not supported. (Supported versions: 42, 43, 44)
    

    Oh, my bad. I didn't know that Gnome 45 is not supported.
    It would be nice to get this message in the UI as well.

  12. daudix commented on Dec 18, 2023

    @daudix
    Member
  13. manan-gup commented on Dec 18, 2023

    @manan-gup

    Hm, it should be, try this build: https://github.com/GradienceTeam/Gradience/actions/runs/7214048889/artifacts/1115721706

    It worked with this build. Thanks!

  14. daudix commented on Dec 18, 2023

    @daudix
    Member

    You're welcome ^^

  15. CaragC commented on Jan 7, 2024

    @CaragC

    Using this build, when clicking the apply button next to "Shell Theming Options", nothing happens. The console prints out the following when running flatpak run com.github.GradienceTeam.Gradience.Devel

    [Gradience] DEBUG: Spawning: ['flatpak-spawn', '--host', 'gnome-shell', '--version']
    
    ** (gradience:2): WARNING **: 15:59:06.037: Failed to load shared library 'libportal.so.1' referenced by the typelib: /app/lib/libportal.so.1: undefined symbol: g_once_init_leave_pointer
    /app/lib/python3.11/site-packages/gradience/backend/globals.py:98: Warning: cannot retrieve class for invalid (unclassed) type 'void'
      portal = Xdp.Portal()
    Traceback (most recent call last):
      File "/app/lib/python3.11/site-packages/gradience/frontend/widgets/shell_theming_group.py", line 113, in on_apply_button_clicked
        user_themes_available = is_shell_ext_installed(ShellTheme().THEME_EXT_NAME)
                                                       ^^^^^^^^^^^^
      File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 75, in __init__
        settings_retriever = FlatpakGSettings if is_sandboxed() else GSettingsSetting
                                                 ^^^^^^^^^^^^^^
      File "/app/lib/python3.11/site-packages/gradience/backend/globals.py", line 98, in is_sandboxed
        portal = Xdp.Portal()
                 ^^^^^^^^^^^^
    TypeError: could not get a reference to type class
    
    

    Is there anyway to fix this?

  16. daudix commented on Jan 7, 2024

    @daudix
    Member

    @CaragC do you have User Themes extension installed? it is needed for the shell theming to work

  17. CaragC commented on Jan 7, 2024

    @CaragC

    Yes it is installed and does not show any Gradience themes. The second theme I installed myself.
    image

  18. daudix commented on Jan 7, 2024

    @daudix
    Member

    Hm, that's weird, can you try the latest build? https://nightly.link/GradienceTeam/Gradience/workflows/build/main

  19. CaragC commented on Jan 7, 2024

    @CaragC

    This still gives the same error as before, also the same error is given when clicking "Reset Theme"

    [Gradience] DEBUG: Spawning: ['flatpak-spawn', '--host', 'gnome-shell', '--version']
    
    ** (gradience:2): WARNING **: 18:35:31.542: Failed to load shared library 'libportal.so.1' referenced by the typelib: /app/lib/libportal.so.1: undefined symbol: g_once_init_leave_pointer
    /app/lib/python3.11/site-packages/gradience/backend/globals.py:98: Warning: cannot retrieve class for invalid (unclassed) type 'void'
      portal = Xdp.Portal()
    Traceback (most recent call last):
      File "/app/lib/python3.11/site-packages/gradience/frontend/widgets/shell_theming_group.py", line 113, in on_apply_button_clicked
        user_themes_available = is_shell_ext_installed(ShellTheme().THEME_EXT_NAME)
                                                       ^^^^^^^^^^^^
      File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 75, in __init__
        settings_retriever = FlatpakGSettings if is_sandboxed() else GSettingsSetting
                                                 ^^^^^^^^^^^^^^
      File "/app/lib/python3.11/site-packages/gradience/backend/globals.py", line 98, in is_sandboxed
        portal = Xdp.Portal()
                 ^^^^^^^^^^^^
    TypeError: could not get a reference to type class
    
    
  20. manan-gup commented on Jan 8, 2024

    @manan-gup

    Failed to load shared library 'libportal.so.1'

    Do you have the xdg-desktop-portal and libportal packages installed?

  21. CaragC commented on Jan 8, 2024

    @CaragC

    Both of the packages are installed

  22. sidevesh commented on Feb 9, 2024

    @sidevesh

    Another issue with Geary after fixing the earlier issue by adding the Adw 1.4 colors to the theme json,
    image
    this happens when window is not in foreground,
    I can't figure out which backdrop or otherwise color maps to this #303030 color.

    EDIT: Earlier this color was #FFF but after a log out and login after applying the theme it turned #303030.

  23. sidevesh commented on Feb 26, 2024

    @sidevesh

    Any idea about the above issue @daudix ?

  24. daudix commented on Feb 26, 2024

    @daudix
    Member

    I've no idea, the version from main has some issues with sidebar theming, you can try beta1 which appears to not have these

  25. macleod-ee commented on Apr 9, 2024

    @macleod-ee

    Gnome 46 support hasn't been added, adding this so others can find it: #871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    • Status
      In Progress

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions