Skip to content

Development #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2018
Merged

Development #7

merged 4 commits into from
Oct 3, 2018

Conversation

kelvinwijaya
Copy link
Contributor

Description

V1.3.0-SNAPSHOT

  • Update test-suites framework to cover more use-case scenarios
  • Add Utility to read from PKI Key with PEM format
  • Update README documentation

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code enhancement and update (non-breaking change)
  • Security patch

How Has This Been Tested?

Junit and new in build test-framework

@coveralls
Copy link

coveralls commented Sep 28, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-4.9%) to 71.257% when pulling 6b66474 on development into 3dbc678 on master.

@GovTechSG GovTechSG deleted a comment Sep 28, 2018
robincher
robincher reviewed Oct 2, 2018
View reviewed changes
robincher
robincher reviewed Oct 2, 2018
View reviewed changes
README.md Outdated
@@ -156,7 +196,7 @@ Params:
* timestamp - set to null for current timestamp

```java
String url = "https://<<URL>>/api/v1/?param1=first&ab-param2=123";
String url = "https://<<Target_URL>>/api/v1/?param1=first&param2=123";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to share that if they put queryParams formList, they no need to put the query param in the URL ?

@GovTechSG GovTechSG deleted a comment Oct 2, 2018
robincher
robincher approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@robincher robincher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for now, can target major rewrite of documentation based on more user feedback

@kelvinwijaya
Copy link
Contributor Author

merge to master for version 1.3.0

@kelvinwijaya kelvinwijaya merged commit ad37ad3 into master Oct 3, 2018
GTYeokh pushed a commit that referenced this pull request Dec 17, 2021
@blasttoys
Merge pull request #7 from blasttoys/development
3dbff9a 
Development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robincher robincher robincher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinwijaya @coveralls @robincher