Skip to content

Development #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 11, 2018
Merged

Development #6

merged 5 commits into from
Sep 11, 2018

Conversation

kelvinwijaya
Copy link
Contributor

Description

Bugs fix for following items:

  • During Base String generation, handle empty value of the key value pair by appending & value
  • Standardise nonce value generation to use 32 bytes and base64 encoded string
  • Verify the support of multiple param with same key

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Code enhancement and update (non-breaking change)

How Has This Been Tested?

Tested using unit test-cases

@coveralls
Copy link

coveralls commented Sep 10, 2018 •
edited
Loading

Coverage Status

Coverage increased (+1.6%) to 76.14% when pulling 50a0c5f on development into 27fa7e9 on master.

robincher
robincher reviewed Sep 10, 2018
View reviewed changes
robincher
robincher previously requested changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@robincher robincher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the gradle / mvn artifact versioning and CHANGELOG

@GovTechSG GovTechSG deleted a comment Sep 11, 2018
@GovTechSG GovTechSG deleted a comment Sep 11, 2018
@GovTechSG GovTechSG deleted a comment from kelvinwijaya Sep 11, 2018
@GovTechSG GovTechSG deleted a comment Sep 11, 2018
@GovTechSG GovTechSG deleted a comment Sep 11, 2018
robincher
robincher approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@robincher robincher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merge to master

@kelvinwijaya kelvinwijaya merged commit 3dbc678 into master Sep 11, 2018
GTYeokh pushed a commit that referenced this pull request Dec 17, 2021
@blasttoys
Merge pull request #6 from blasttoys/dirtyUpdate
3a8e159 
clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robincher robincher robincher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinwijaya @coveralls @robincher