Ct 866/migrate hook tests fixed (dbt-labs#5760)

* Finish converting first test file. * Finish test conversion. * Remove old integration hook tests. * Move location of schema.yml to models directory. * fix snapshot delete test that was failing * Add the extra env var check for our CI. * Add changelog * Remove naive json flag check and instead force all integration tests to check for environment variables using flag routine. * Revise the changelog to be more of an explanation. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
Gousto · Sep 16, 2022 · 9f43219 · 9f43219
1 parent 9e1f6c0
commit 9f43219
Show file tree

Hide file tree

Showing 25 changed files with 912 additions and 831 deletions.
diff --git a/.changes/unreleased/Under the Hood-20220905-001749.yaml b/.changes/unreleased/Under the Hood-20220905-001749.yaml
@@ -0,0 +1,7 @@
+kind: Under the Hood
+body: Migrate integration test 014 but also fix the snapshot hard delete test's timezone logic and force all integration tests to run flags.set_from_args to force environment variables are accessible to all integration test threads.
+time: 2022-09-05T00:17:49.564534-07:00
+custom:
+  Author: versusfacit
+  Issue: "5760"
+  PR: "5760"
diff --git a/core/dbt/events/functions.py b/core/dbt/events/functions.py
@@ -57,6 +57,7 @@ def setup_event_logger(log_path, level_override=None):
     EVENT_HISTORY = deque(maxlen=flags.EVENT_BUFFER_SIZE)  # type: ignore
 
     make_log_dir_if_missing(log_path)
+
     this.format_json = flags.LOG_FORMAT == "json"
     # USE_COLORS can be None if the app just started and the cli flags
     # havent been applied yet

diff --git a/test/integration/014_hook_tests/configured-models/hooks.sql b/test/integration/014_hook_tests/configured-models/hooks.sql
diff --git a/test/integration/014_hook_tests/error-models/hooks.sql b/test/integration/014_hook_tests/error-models/hooks.sql
diff --git a/test/integration/014_hook_tests/kwargs-models/hooks.sql b/test/integration/014_hook_tests/kwargs-models/hooks.sql
diff --git a/test/integration/014_hook_tests/macros/before-and-after.sql b/test/integration/014_hook_tests/macros/before-and-after.sql
diff --git a/test/integration/014_hook_tests/macros/hook.sql b/test/integration/014_hook_tests/macros/hook.sql
diff --git a/test/integration/014_hook_tests/models/hooks.sql b/test/integration/014_hook_tests/models/hooks.sql
diff --git a/test/integration/014_hook_tests/ref-hook-models/hooked.sql b/test/integration/014_hook_tests/ref-hook-models/hooked.sql
diff --git a/test/integration/014_hook_tests/ref-hook-models/post.sql b/test/integration/014_hook_tests/ref-hook-models/post.sql
diff --git a/test/integration/014_hook_tests/ref-hook-models/pre.sql b/test/integration/014_hook_tests/ref-hook-models/pre.sql
diff --git a/test/integration/014_hook_tests/seed-models/schema.yml b/test/integration/014_hook_tests/seed-models/schema.yml
diff --git a/test/integration/014_hook_tests/seeds/example_seed.csv b/test/integration/014_hook_tests/seeds/example_seed.csv
diff --git a/test/integration/014_hook_tests/test-kwargs-snapshots/snapshots.sql b/test/integration/014_hook_tests/test-kwargs-snapshots/snapshots.sql
diff --git a/test/integration/014_hook_tests/test-snapshot-models/schema.yml b/test/integration/014_hook_tests/test-snapshot-models/schema.yml
diff --git a/test/integration/014_hook_tests/test-snapshots/snapshots.sql b/test/integration/014_hook_tests/test-snapshots/snapshots.sql