Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a hook for task undo #2213

Closed
jspricke opened this issue Sep 13, 2019 · 0 comments
Closed

Add a hook for task undo #2213

jspricke opened this issue Sep 13, 2019 · 0 comments

Comments

@jspricke
Copy link
Contributor

My hook scripts export the data to my calendar but hook scripts are not run when using task undo. I would propose to run a on-undo or on-modify hook script when executing task undo. Input would be the old an new (i.e. reverted) JSON and output nothing (maybe have an exit > 0 discard the undo?)
jspricke added a commit to jspricke/taskwarrior that referenced this issue Sep 13, 2019
@jspricke
hook onModify into task undo (Closes: GothenburgBitFactory#2213)
4b77c83
mrossinek added a commit to mrossinek/taskwarrior that referenced this issue Nov 21, 2020
@mrossinek
Fix Undo command
474828f 
The Undo command broke in 48dff11 when the `onModify` hook got added to
its execution in order to fix GothenburgBitFactory#2213. The reason for it begin broke is
that a Task object is created in an unsafe manner because the `prior`
task may be empty.
Catching this case fixes the bug.
tbabej pushed a commit that referenced this issue Nov 30, 2020
@mrossinek @tbabej
Fix Undo command
44bcd58 
The Undo command broke in 48dff11 when the `onModify` hook got added to
its execution in order to fix #2213. The reason for it begin broke is
that a Task object is created in an unsafe manner because the `prior`
task may be empty.
Catching this case fixes the bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jspricke