Include github private repos (take 2). Fix #282. #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryneeverett
force-pushed
the
fix-github-private-repos
branch
from
7ea467c
to
f0b6458
Compare
It seems that the distinction was not properly documented for some time, but it now is. `/user/repos` includes all repos the authorized user has access to, but `/users/:username/repos` only includes public repos. http://stackoverflow.com/questions/21907278/github-api-using-repo-scope-but-still-cant-see-private-repos
ryneeverett
force-pushed
the
fix-github-private-repos
branch
from
f0b6458
to
b0cee49
Compare
|
It looks fine to me now 👍 |
|
Cool. It would be nice is somebody with private github repos confirmed that this works before merging. |
|
I would, but I don't have any private repos myself. :/ |
|
I tried soliciting testers from some private-repo-users I know, but no one bit. Let's go ahead and merge this and then see if anything pops up. |
|
Fair enough. I've been using this with public repos without issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the distinction was not properly documented for some time,
but it now is.
/user/reposincludes all repos the authorized user hasaccess to, but
/users/:username/reposonly includes public repos.http://stackoverflow.com/questions/21907278/github-api-using-repo-scope-but-still-cant-see-private-repos
Note: This doesn't break anything for me but I'm not super familiar with the configuration options and am not sure if this might accidentally change their behavior.