Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal CI and documentation fixes. #273

Merged

Conversation

ryneeverett
Copy link
Collaborator

Simply running nosetests wont work because dependencies aren't installed
in the virtualenv. You'd have to manually pip install each dependency
like travis currently does.

Nose recommends this as "the easiest way to run tests with nose".
http://nose.readthedocs.org/en/latest/api/commands.html

Simply running nosetests wont work because dependencies aren't installed
in the virtualenv. You'd have to manually pip install each dependency
like travis currently does.

Nose recommends this as "the easiest way to run tests with nose".
http://nose.readthedocs.org/en/latest/api/commands.html
@coddingtonbear
Copy link
Collaborator

I think the best way forward might be to just instruct people to run python setup.py test for running tests; that should install the necessary dependencies automatically.

@ryneeverett
Copy link
Collaborator Author

@coddingtonbear python setup.py nosetests seems to be the same thing but with nosetests as the testrunner. If you want to stop suggesting people use nose as a testrunner that's fine by me, but this way you can have your cake and eat it too.

@coddingtonbear
Copy link
Collaborator

@ryneeverett -- my understanding is that since we've set nose.collector as our test suite, nose will always be the test runner, is that not your understanding?

@coddingtonbear
Copy link
Collaborator

Actually -- I have to admit that I hadn't read your PR very carefully before posting my first comment above. I'm +1 on making either the change you've suggested or the one I have.

@ryneeverett
Copy link
Collaborator Author

my understanding is that since we've set nose.collector as our test suite, nose will always be the test runner, is that not your understanding?

@coddingtonbear That makes sense, but when I run python setup.py test I don't get the nose output, I get standard unittest output.

@ryneeverett ryneeverett changed the title Fix test command documentation. Minimal CI and documentation fixes. Jan 29, 2016
@ralphbean
Copy link
Collaborator

Good stuff. Thanks both!

ralphbean added a commit that referenced this pull request Feb 17, 2016
@ralphbean ralphbean merged commit e3e036b into GothenburgBitFactory:develop Feb 17, 2016
ryneeverett added a commit to ryneeverett/bugwarrior that referenced this pull request Mar 25, 2016
We dropped python 2.6 from CI in GothenburgBitFactory#273 so the backport is no longer
needed.
ryneeverett added a commit to ryneeverett/bugwarrior that referenced this pull request Mar 25, 2016
We dropped python 2.6 from CI in GothenburgBitFactory#273 so the backport is no longer
needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants