Use setuptools entry points instead of DeferredImport #245
Conversation
|
Ahh, @puiterwijk, @ralphbean & I had discussed making this kind of change a year or so ago, but there were some reservations (which may by this point not be great) raised. @ralphbean what do you think? |
|
No, I don't remember the points in our original discussion @coddingtonbear. I'll try to have a look at this soon! |
|
If it helps, and if you log our conversations on Freenode, it was there -- search for "entrypoint" or something like that. I think I may have been using my former office's computer at the time, so I'm not sure I still have the transcripts. |
|
Unfortunately I don't still have those logs. Anyways, the code change looks fine to me. And I suppose it would be nice to allow external plugins. Let's let it sit a few more days, but I'm inclined to approve and merge this unless you have any objections @coddingtonbear. |
puiterwijk
force-pushed
the
flexible-services
branch
2 times, most recently
from
b4f0696
to
b9b9d5a
Compare
|
Pull request rebased. |
puiterwijk
force-pushed
the
flexible-services
branch
from
b9b9d5a
to
6a20362
Compare
This way, it is possible to use services implemented in external packages Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
puiterwijk
force-pushed
the
flexible-services
branch
from
6a20362
to
0750259
Compare
|
👍. Thanks Patrick! :) Happy plugin-writing! |
Use setuptools entry points instead of DeferredImport
|
Thank you very much! |
This way, it is possible to use services implemented in external
packages
Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com