Fix Chinese filename encoding in ZIP extraction #1260
Draft
+129
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZIP archives created on Windows with Chinese filenames use GBK/GB18030 encoding. Without explicit charset configuration, filenames display as mojibake (e.g.,
1-�� - 1����.STLinstead of装配件1 - 盖-2.STL).Changes
newZipFormat()helper that createsarchives.ZipwithTextEncoding: simplifiedchinese.GB18030openArchive()for regular ZIP files andextractZipMultiPart()for split archivesImplementation
The
mholt/archiveslibrary checks the UTF-8 flag in ZIP headers and usesTextEncodingfor non-UTF8 filenames. GB18030 is a superset of GBK and handles legacy Chinese-encoded archives.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.