2.0 preview #376
2.0 preview #376
Conversation
2.0 preview
To make sure this implement can be cleanly installed in a Polymer 2 application, use the latest stable versions of most of the elements.
Update dependency versions to latest version
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
bower.json
Outdated
| "iron-resizable-behavior": "PolymerElements/iron-resizable-behavior#^1.0.5", | ||
| "iron-selector": "PolymerElements/iron-selector#^1.5.2" | ||
| "polymer": "Polymer/polymer#1.9 - 2", | ||
| "google-apis": "GoogleWebComponents/google-apis#2.0-preview", |
There was a problem hiding this comment.
@e111077 Please change it to google-apis#^2.0.0. Recently v2.0.0 of <google-apis> has been released: https://github.com/GoogleWebComponents/google-apis/releases/tag/v2.0.0.
There was a problem hiding this comment.
@e111077 Oh, this should be google-apis#1 - 2 instead of google-apis#^2.0.0. Could you please change it and bump version of google-map to 2.0.1?
There was a problem hiding this comment.
This is actually not compatible with v1 google-apis
There was a problem hiding this comment.
@e111077 Hm, this is very strange. Seems you're wrong. In line 44 we use v1 of google-apis. All this time before yesterday this pull request was merged, google-map used v1 of google-apis and it worked like a charm.
There was a problem hiding this comment.
Ah okay, I'll give it another test in the office
There was a problem hiding this comment.
@e111077 Just a reminder. ;)
There was a problem hiding this comment.
Actually can you make a PR for it. It'll be the fastest way to get it merged due to our workflow
bower.json
Outdated
| "variants": { | ||
| "1.x": { | ||
| "dependencies": { | ||
| "polymer": "Polymer/polymer#^1.8.0", |
There was a problem hiding this comment.
@e111077 Please change it to polymer#^1.9.0. If we use 1.9 as minimum version in line 31, i.e. 1.9 - 2, we should use the same version, i.e. 1.9.0, in line 43.
|
@ebidel PTAL. |
|
lgtm |
2.0 hybrid.
Breaking changes: slot name required for markers