-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change bazel example #9218
chore: change bazel example #9218
Conversation
ericzzzzzzz
commented
Dec 12, 2023
•
edited
Loading
edited
- github actions CI is broken due to upstream docker rule changes, as it's also deprecated now https://github.com/bazelbuild/rules_docker, we should move our bazel example to use oci rule
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9218 +/- ##
==========================================
- Coverage 70.48% 63.67% -6.82%
==========================================
Files 515 632 +117
Lines 23150 32545 +9395
==========================================
+ Hits 16317 20722 +4405
- Misses 5776 10232 +4456
- Partials 1057 1591 +534 ☔ View full report in Codecov by Sentry. |
@ericzzzzzzz @renzodavid9 would it also make sense to remove this limitation on the target name? It was mostly due to skaffold/pkg/skaffold/build/bazel/build.go Lines 62 to 64 in c4af00e
|
@ar3s3ru agree to remove the validation. |