Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use moby/patternmatcher for dockerignore #9029

Merged

Conversation

maximdeclercq
Copy link
Contributor

Description
This makes the exclude rule matching use the native moby patternmatcher.

This allows for complex patterns as the one below and is more streamlined with the buildkit implementation.

*
!**/.cargo/
!**/*.rs
!**/Cargo.toml
!**/Cargo.lock
target/*

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #9029 (fda20e5) into main (290280e) will decrease coverage by 6.86%.
Report is 1004 commits behind head on main.
The diff coverage is 49.90%.

@@            Coverage Diff             @@
##             main    #9029      +/-   ##
==========================================
- Coverage   70.48%   63.62%   -6.86%     
==========================================
  Files         515      624     +109     
  Lines       23150    31928    +8778     
==========================================
+ Hits        16317    20314    +3997     
- Misses       5776    10083    +4307     
- Partials     1057     1531     +474     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 417 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz added the kokoro:run runs the kokoro jobs on a PR label Aug 17, 2023
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Aug 17, 2023
@ericzzzzzzz ericzzzzzzz merged commit 7521ea2 into GoogleContainerTools:main Aug 17, 2023
15 checks passed
@maximdeclercq maximdeclercq deleted the fix/dockerignore-wildcard branch August 18, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants