-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix render and deploy when using kustomize and helm deployer. #7723
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7723 +/- ##
==========================================
- Coverage 70.48% 66.61% -3.88%
==========================================
Files 515 587 +72
Lines 23150 28239 +5089
==========================================
+ Hits 16317 18811 +2494
- Misses 5776 8051 +2275
- Partials 1057 1377 +320
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Seems there is a test error atm:
also a small lint error related to a newline |
fixed it. Some bad rebasing. |
1e694c2
to
1fb27e2
Compare
e7546cc
to
97d3d3d
Compare
97d3d3d
to
6260358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
96b8088
to
20c382e
Compare
In this PR,
Completely addressing the issue #7675 to support backward compatibility.
Changes in this PR
In the above example, skaffold was configured to deploy helm charts. The frontend k8s manifests were rendered but never deployed.
skaffold render
with legacy helm deploy stanza, force helm rendering.In the above same config, only kubectl manifests were rendered with
skaffold render
. This behavior is backward incompatible.=== TODO
render.helm.releases
anddeploy.helm.release
makes sense. @marlon-gamez discussed before it could be confusing to remove these duplicated fields.