Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add test for filter command #7317

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Apr 15, 2022

This is one of the tasks for #6683

Adding a test for filter command. This will copied over to v1 branch.

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #7317 (46864ec) into main (290280e) will decrease coverage by 3.11%.
The diff coverage is 58.37%.

@@            Coverage Diff             @@
##             main    #7317      +/-   ##
==========================================
- Coverage   70.48%   67.37%   -3.12%     
==========================================
  Files         515      559      +44     
  Lines       23150    26684    +3534     
==========================================
+ Hits        16317    17978    +1661     
- Misses       5776     7415    +1639     
- Partials     1057     1291     +234     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <0.00%> (-1.85%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 36.66% <14.28%> (-4.72%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 54.09% <38.88%> (-22.38%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <46.15%> (+0.24%) ⬆️
cmd/skaffold/app/cmd/diagnose.go 70.27% <50.00%> (+5.40%) ⬆️
... and 265 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tejal29 tejal29 merged commit 1677c6e into GoogleContainerTools:main Apr 19, 2022
bskaplan pushed a commit to bskaplan/skaffold that referenced this pull request Apr 26, 2022
* chore: add test for manifest transform

* chore: add tests for filter command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants